Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covers do not update on all refresh #1554

Open
8 tasks done
ziomek64 opened this issue Apr 25, 2024 · 11 comments
Open
8 tasks done

Covers do not update on all refresh #1554

ziomek64 opened this issue Apr 25, 2024 · 11 comments

Comments

@ziomek64
Copy link

Steps to reproduce

  1. Covers don't update on pull down in library
  2. Covers don't update on advanced->update covers
  3. Covers update on pull down in opened entry

Expected behavior

Covers should update in all scenarios mentioned or at least 2 and 3

Actual behavior

Covers update only in pull down in entry

Crash logs

No response

Aniyomi version

0.15.2.4

Android version

Android 14

Device

Xiaomi pad 6

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.15.2.4.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@fakebhai
Copy link
Contributor

can you show examples or specific cases?

@ziomek64
Copy link
Author

can you show examples or specific cases?

Like what exactly? Happens everywhere, I was surprised I could update like 10 covers. Some sources don't update covers but mangasee does for new volumes etc.

@ziomek64
Copy link
Author

@ShadowWalkerM
Copy link

ShadowWalkerM commented May 4, 2024

Bro try turn off smart update and refresh

@fakebhai
Copy link
Contributor

fakebhai commented May 4, 2024

Bro try turn off smart update and refresh

smart update isn't relevant at all when you update any entry manually. as it clearly falls under "global update".

@fakebhai
Copy link
Contributor

fakebhai commented May 4, 2024

I think option in advanced settings just re-fetches from same available Metadata. as it says "refresh library covers" so I suppose it's used in cases like covers weren't loaded when you added your entry or restored your backup (using same metadata/image-url).

you'll need to make it re-fetch whole Metadata which in this case is available at "more - settings - library - automatically refresh metadata"

@ziomek64
Copy link
Author

ziomek64 commented May 4, 2024

I think option in advanced settings just re-fetches from same available Metadata. as it says "refresh library covers" so I suppose it's used in cases like covers weren't loaded when you added your entry or restored your backup (using same metadata/image-url).

you'll need to make it re-fetch whole Metadata which in this case is available at "more - settings - library - automatically refresh metadata"

It's already turned on for me. Smart is off. Is the code the same for single update and whole library?

@fakebhai
Copy link
Contributor

fakebhai commented May 4, 2024

It's already turned on for me. Smart is off. Is the code the same for single update and whole library?

smart update and global update settings apply when you refresh your library or category, it doesn't apply if you open any anime/manga entry and refresh it

@ziomek64
Copy link
Author

ziomek64 commented May 4, 2024

Sure, but I'm asking if the code for updating single entry and all is the same. Because it's really weird covers don't update when refreshing whole library.

@fakebhai
Copy link
Contributor

fakebhai commented May 5, 2024

Sure, but I'm asking if the code for updating single entry and all is the same. Because it's really weird covers don't update when refreshing whole library.

good that it isn't, someone with big library size will ddos those sources. but I believe it'll only refresh metadata of unskipped entries but I could be wrong

@ShadowWalkerM
Copy link

Bro try turn off smart update and refresh

smart update isn't relevant at all when you update any entry manually. as it clearly falls under "global update".

Sorry didnt know that but it worked for me lol idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants