Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to the displayed Quote upon notification click #111

Open
Jonykkd opened this issue Apr 3, 2022 · 4 comments
Open

Open to the displayed Quote upon notification click #111

Jonykkd opened this issue Apr 3, 2022 · 4 comments
Labels
feature-request New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Jonykkd
Copy link

Jonykkd commented Apr 3, 2022

When Clicked on the Notification, it is not redirecting to same quote, which is displayed on Notification Bar.

@VishnuSanal
Copy link
Owner

@Jonykkd Hello!

Thanks for reporting!

When Clicked on the Notification, it is not redirecting to same quote, which is displayed on Notification Bar.

Yes! The actions present on notification are to share & add to favourites. The share action is extended to a click on notification too (not only on the share button). So, to share the quote or to add them to favourites, the app should be opened. Then the share bottom sheet pops up (or triggers the default share action) or adds the Quote to favourites & gives a feedback to the user via a Toast message.

Due to this it's not necessary to display the same Quote as that of the notification. This is the same behaviour for widgets too.

Hope this answers your question. Thanks a ton for reporting & feel free to revert back if you've any more queries :)

@Jonykkd
Copy link
Author

Jonykkd commented Apr 5, 2022

@VishnuSanal Hi,
Thank You for your reply. I agree with you that it might not be required for the user to get the notification click redirects the same quote. But, If we want it really, how should we achieve it? Just to learn about the notification action of this. Thank you!

@VishnuSanal
Copy link
Owner

@Jonykkd Hi!

Thanks for showing interest.

The notification click (widget click & shortcut action click too) redirects to the MainActivity. Then the specifics are handled there.

Also, I feel like, if we want to achieve the behaviour, we can add the Quote from the notification to the first position (index zero) in the list & pass it onto the Quotes' list & then submit the list to the ViewPagerAdapter.

Hope this answers your question. Feel free to revert back if you've any more queries. :)

PS: Excuse my brevity - answered from smartphone without referring to the actual code!

@VishnuSanal
Copy link
Owner

The notification click (widget click & shortcut action click too) redirects to the MainActivity. Then the specifics are handled there.

Also, I feel like, if we want to achieve the behaviour, we can add the Quote from the notification to the first position (index zero) in the list & pass it onto the Quotes' list & then submit the list to the ViewPagerAdapter.

I feel this can be converted into a feature request. Adding good-first-issue label too, since this is an easy fix!

@VishnuSanal VishnuSanal added feature-request New feature or request good first issue Good for newcomers and removed issue-discussion labels Aug 19, 2023
@VishnuSanal VishnuSanal changed the title Notification Click Action! Open to the displayed Quote upon notification click Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants