Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Cleanup classes with very strange design #5164

Open
6 tasks
vil02 opened this issue May 18, 2024 · 1 comment
Open
6 tasks

[OTHER] Cleanup classes with very strange design #5164

vil02 opened this issue May 18, 2024 · 1 comment

Comments

@vil02
Copy link
Member

vil02 commented May 18, 2024

What would you like to share?

There are probably many classes in this repository, which have some strange design - we should update all of them. I think we can start with cleaning up these:

List of the classes needing redesign:

(@siriak, @BamaCharanChhandogi feel free to edit the list above)

Additional information

How to contribute

  1. select one class form the list above such that no one else is working on (and is not done yet),
  2. write a comment "Hey, I am working on XYZ", where XYZ is your selected class,
  3. in your fork, please create a branch like cleanup_XYZ,
  4. make your changes and create a pull-request, in which you mention this issue by writing something like "Related to #(this issue number)". Please make sure that you add all necessary tests. If possible, prefer parametrized tests.

Also feel free to suggest a class, which should be added to the list above.

@vil02 vil02 added the awaiting triage Awaiting triage from a maintainer label May 18, 2024
@siriak siriak added enhancement help wanted and removed awaiting triage Awaiting triage from a maintainer labels May 21, 2024
@yuvashreenarayanan3
Copy link

Hey, I am working on "ArrayCombination"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants