Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when voting series #985

Open
t0815 opened this issue Jan 10, 2019 · 2 comments
Open

Exception when voting series #985

t0815 opened this issue Jan 10, 2019 · 2 comments

Comments

@t0815
Copy link

t0815 commented Jan 10, 2019

VERSION INFORMATION

Server Version: 3.9.4.30902

Desktop Version: 3.9.4.0

LOG FILE

[2019-01-10 20:52:01:367] Error|RatingControl.OnRatingValueChanged => AnimeSeries.cRating_OnRatingValueChangedEvent => Utils.ShowErrorMessage System.AggregateException: One or more errors occurred. ---> Nancy.Rest.Client.Exceptions.RestClientException: 7.5 is not a valid value for Decimal. at Nancy.Rest.Client.Rest.SmallWebClient.<RestRequest>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Nancy.Rest.Client.ClientFactory.<>c__DisplayClass2_0.<<DoSyncClient>b__0>d.MoveNext() --- End of inner exception stack trace --- at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification)
at Nancy.Rest.Client.ClientFactory.DoSyncClient(Object dexp, MethodDefinition def, IWebProxy proxy, Object[] parameters)
at Nancy.Rest.Client.ClientFactory.<>c__DisplayClass1_11.<Create>b__15(Object a, Object b, Object c) at CallSite.Target(Closure , CallSite , Object , Int32 , Decimal , Int32 ) at ActLike_IShokoServer_673012258df8497da7b6fb7279ad42e6.VoteAnime(Int32 animeID, Decimal voteValue, Int32 voteType) at Shoko.Desktop.UserControls.AnimeSeries.cRating_OnRatingValueChangedEvent(RatingValueEventArgs ev) in D:\Documents\GitHub\ShokoDesktop\Shoko.Desktop\UserControls\AnimeSeries.xaml.cs:line 1307 ---> (Inner Exception #0) Nancy.Rest.Client.Exceptions.RestClientException: 7.5 is not a valid value for Decimal. at Nancy.Rest.Client.Rest.SmallWebClient.<RestRequest>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Nancy.Rest.Client.ClientFactory.<>c__DisplayClass2_0.<<DoSyncClient>b__0>d.MoveNext()<---

DESCRIPTION

Upon using the voting-widget you will get an exception when using floatingpoint number scores.

STEPS TO REPRODUCE

  1. Find anime not voted yet
  2. vote a score x.5
  3. (int score will work, to verify vote flat score)
@ElementalCrisis ElementalCrisis transferred this issue from ShokoAnime/ShokoDesktop Aug 5, 2022
@Cazzar
Copy link
Member

Cazzar commented Aug 6, 2022

If this is even happening still (also given da3dsoul’a anidb rewrite, we will also need server logs

@t0815
Copy link
Author

t0815 commented Apr 11, 2023

The exception has been fixed. But the score is somehow getting displayed as integer, thus converting 3.5 to 35.
If its a flat vote like 3 it will stay 3

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants