Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support for baseUrl or Prefix #955

Open
fossison opened this issue Feb 19, 2022 · 1 comment
Open

Feature request: Support for baseUrl or Prefix #955

fossison opened this issue Feb 19, 2022 · 1 comment

Comments

@fossison
Copy link

fossison commented Feb 19, 2022

Shoko should support baseUrl or prefix settings, either through the web interface (and thus manually set within the application) or through the nginx header X-Script-Path (and thus configured at the server level instead, with Shoko operating as expected when the header is passed).

Use case: Placing Shoko behind a reverse proxy. Shoko right now can only be hosted on the root directory on a server instance, whether it be on a subdomain or main domain. This is because Shoko has no way to rewrite the urls when placed behind a reverse proxy.

Adding support for this would enable reverse proxy use for shoko using a location directive, e.g.

location /shoko/ {
    proxy_pass http://127.0.0.1:8111/;
}
@ElementalCrisis ElementalCrisis transferred this issue from ShokoAnime/Shoko-WebUI Aug 5, 2022
@Cazzar
Copy link
Member

Cazzar commented Aug 6, 2022

This will likely not happen for a while as there is APIs exposed as part of Shoko Server’s support for Desktop that can be considered relatively insecure.

further to this, at a web server level (like nginx) you can usually rewrite URLs like this; https://www.nginx.com/blog/creating-nginx-rewrite-rules/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants