Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullReferenceException in CommandRequest_AddFileToMyList #908

Open
bigretromike opened this issue Oct 19, 2021 · 1 comment
Open

NullReferenceException in CommandRequest_AddFileToMyList #908

bigretromike opened this issue Oct 19, 2021 · 1 comment

Comments

@bigretromike
Copy link
Contributor

VERSION INFORMATION

Server Version: 4.1.1.0

Desktop Version:

If you've compiled your own version, please use the last commit you compiled.

LOG FILE

2021-10-18T18:27:20.5734228Z
Trying to load 16038 anime data from cache.
2021-10-18T18:27:20.5734228Z
GetAnimeXMLFromAPI: banned, not getting
2021-10-18T18:27:20.5734228Z
Failed get anime info for 16038. AniDB ban or No Such Anime returned
2021-10-18T18:27:20.5734228Z
Unable to create AniDB_Anime for file: [SubsPlease] Seven Knights Revolution - Eiyuu no Keishousha - 12 (1080p) [D43F9541].mkv
2021-10-18T18:27:20.5734228Z
Queuing GET for AniDB_Anime: 16038
2021-10-18T18:27:20.6163462Z
Processing CommandRequest_AddFileToMyList: [SubsPlease] Seven Knights Revolution - Eiyuu no Keishousha - 12 (1080p) [D43F9541].mkv - 50353D4048CCE082D3649EF7092A0FA0 - True
2021-10-18T18:27:24.5885079Z
Added File to MyList. File: [SubsPlease] Seven Knights Revolution - Eiyuu no Keishousha - 12 (1080p) [D43F9541].mkv Manual Link: False Watched Locally: False Watched AniDB: False Local State: HDD AniDB State: HDD ReadStates: True ReadWatched Setting: True ReadUnwatched Setting: True
2021-10-18T18:27:24.5885079Z
Error processing CommandRequest_AddFileToMyList: 50353D4048CCE082D3649EF7092A0FA0 - System.NullReferenceException: Object reference not set to an instance of an object. at Shoko.Server.Commands.CommandRequest_AddFileToMyList.ProcessCommand() in E:\Documents\GitHub\ShokoServer\Shoko.Server\Commands\AniDB\CommandRequest_AddFileToMyList.cs:line 64

DESCRIPTION

I would assume that nullreferenceexception is because AniDB didn't return anything, because of ban ? those errors throw off a bit, would be good to 'handle' them as the internal state knows anidb is banned.

I'm leaving this info here so if anyone looking for error massage can get into this issue.

STEPS TO REPRODUCE

Being as detailed as possible, please list all steps need to reproduce the issue, if we can't reproduce it then we can't fix it.

@Cazzar Cazzar changed the title Silent error while client is banned ? NullReferenceException in CommandRequest_AddFileToMyList Oct 19, 2021
@Cazzar
Copy link
Member

Cazzar commented Oct 19, 2021

Issue isn't due to the ban, most likely the logger wasn't coming up properly:

logger.Info($"Processing CommandRequest_AddFileToMyList: {vid?.FileName} - {Hash} - {ReadStates}");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants