Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescan files and move appropriately when they are moved on AniDB #758

Open
da3dsoul opened this issue Sep 19, 2018 · 11 comments
Open

Rescan files and move appropriately when they are moved on AniDB #758

da3dsoul opened this issue Sep 19, 2018 · 11 comments

Comments

@da3dsoul
Copy link
Member

This will require aid from AniDB, as I'm not sure if we receive notification of this in UPDATE or what. Regardless, it is annoying that files may be moved and we need to manually find the file and rescan it, then move it.

@ElementalCrisis
Copy link
Member

Yeah I don't think this is supported by their API.

This is really only an issue for users who have to have the latest episode from an airing series. Could be built upon with #504 where series that currently airing have their files rechecked to see if they have moved.

@da3dsoul
Copy link
Member Author

Not only, but that is definitely the most common case.

@da3dsoul
Copy link
Member Author

da3dsoul commented Sep 19, 2018

I've left a post on AniDB here

@bigretromike
Copy link
Contributor

This could be a game changer.
Because if there is aid on that list you can getinfo, and if not prevent from asking for it because nothing changed.

@da3dsoul
Copy link
Member Author

...we wouldn't want aid. We want fid

@da3dsoul
Copy link
Member Author

If it's aid, then what happens when a file in One Piece moves? We rescan every file? No we just get a list of fids and update those if we have them

@bigretromike
Copy link
Contributor

yeah i meant fid, also if aid changed we would like to scan series for updated info

@da3dsoul
Copy link
Member Author

We have another endpoint for that, but yeah

@revam
Copy link
Member

revam commented Sep 5, 2023

Just leaving a comment for future lurkers, but this can be done by subscribing to general AniDB notifications updates in the UDP API, then reacting to the file moved notifications sent by the system.

But to do this properly we first should lay the ground work to add support for AniDB notifications. And maybe even server notifications in general and hook the AniDB notifications into the general notification system.

Or we could just do it quick and dirty and only add some code to check the AniDB notifications and react to the file move events, but that will mean we will lose any and all notifications we went through to check for file events into the void of time, lost forever in the UDP API. (The users can still check the notifications on AniDB themselves, we just can't check them in the UDP API again.)

@bigretromike
Copy link
Contributor

@revam also if anidb notifications are global there could web-worker that would fetch that and those information could be fetched from cache first ? if notifications are private/account linked then sorry.

@revam
Copy link
Member

revam commented Nov 18, 2023

Notifications are only through the udp api, and are tied to the user. There is no api where a "web-worker" would be useful, as we would need to coordinate it using our anidb udp api handler. Neither is there any cache for us to use, because again, the notifications are tied to the user and only (officially) accessible to us through the UDP API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
NET Standard
Awaiting triage
Development

No branches or pull requests

4 participants