Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: renaming episodes #922

Open
papaj-na-wrotkach opened this issue Jan 29, 2023 · 8 comments
Open

feature: renaming episodes #922

papaj-na-wrotkach opened this issue Jan 29, 2023 · 8 comments

Comments

@papaj-na-wrotkach
Copy link

papaj-na-wrotkach commented Jan 29, 2023

Add ability for user to manually rename episodes (just like for series)

@papaj-na-wrotkach
Copy link
Author

@revam
Copy link
Member

revam commented Jan 29, 2023

Add ability for user to manually rename episodes (just like for seasons)

We don't have season data (except the season numbers from TvDB)

@papaj-na-wrotkach
Copy link
Author

I don't know what do you mean. The episode names are received from anidb aren't they?
image

image

@da3dsoul
Copy link
Member

You meant series, not season, and revam misunderstood, from what I can tell

@papaj-na-wrotkach
Copy link
Author

Yeah, I meant series
I am used to treat seasons and series as the same since anidb makes no distinction between them
Good thing it was noticed, I should stick with the adequate term

@revam
Copy link
Member

revam commented Jan 29, 2023

You meant series, not season, and revam misunderstood, from what I can tell

I knew what he (or she) meant, but i also saw what he (or she) wrote. And no, i didn't have to comment on it, but i did. I was in the mood to comment on little things like that.

Yeah, I meant series I am used to treat seasons and series as the same since anidb makes no distinction between them Good thing it was noticed, I should stick with the adequate term

It's not that they make no distinction between the two, it's because to AniDB there is no such thing as a 'season'.

Also, TMDB (The Movie Database) has season data (season names and overviews/descriptions) that will be added in the future at some point. Idk when.

Anyways, it wouldn't be that hard to add support for custom episode names, but since we have other priorities at the moment and this is an OSS project driven by motivation, then it might be a while until it will be added (unless @da3dsoul (or somebody else) suddenly got the motivation to do it right now).

revam referenced this issue in ShokoAnime/ShokoServer May 28, 2024
- Added Shoko metadata events for when a series or episode is added, updated and removed, available both through the plugin abstraction and through SignalR.

- Added episode title override, finally closing #1041(at least for the api/server aspect of it).
@revam revam transferred this issue from ShokoAnime/ShokoServer May 28, 2024
@revam
Copy link
Member

revam commented May 28, 2024

I did a thing in the spur of the moment, so now the API supports it, but we still need to add UI for it, so I'm transferring this issue to the Web UI repository for now.

@ElementalCrisis
Copy link
Member

We currently do not plan to support this feature due to its limited use case, as our resources can be better utilized on more pressing tasks.

While we won't prevent anyone from attempting to implement this feature, please be aware that it will not be a straightforward pull request. You'll need to get the design approved by us first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants