Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barcodes_generator_abstract: 'barcode_rule_id' value not respected in create() of 'barcode.generate.mixin' #539

Closed
carmenbianca opened this issue Oct 23, 2023 · 1 comment
Labels
bug stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@carmenbianca
Copy link
Member

Module

barcodes_generator_abstract (in combination with barcodes_generator_product).

Describe the bug

When creating a product and manually selecting the barcode rule during creation, that rule is not applied if another barcode rule is set as automated.

To Reproduce

Affected versions: 12, probably later.

Steps to reproduce the behavior:

  1. Install barcodes_generator_product
  2. Enable automation (with sequence) on the product module's barcode.rule.
  3. Create a new barcode.rule for products. Enable generation for it (optional, but makes testing easier).
  4. Create a new product. During product creation, select the newly created barcode.rule.
  5. The module's barcode.rule generation is applied, but the new barcode.rule is saved to the product. If you click on 'generate barcode', the new barcode.rule's generation is applied.

Expected behavior
The automated barcode.rule generation is not applied to products that specify a different barcode.rule generation. Optionally, if the specified barcode.rule allows generation, apply it automatically. Not optionally, if the specified barcode.rule is the one with automation, then apply the generation.

Additional context
I'm working on seeing if the module is compatible with pos_price_to_weight.

Related to #538

Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

1 participant