Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow logic is backwards #130

Open
julianlam opened this issue Jul 14, 2020 · 1 comment
Open

Follow logic is backwards #130

julianlam opened this issue Jul 14, 2020 · 1 comment
Assignees
Labels

Comments

@julianlam
Copy link
Member

For rewriting when this API is merged into core...

Follow's API is of the format /api/v2/users/:uid/follow where :uid is the person to follow, and _uid (or the uid from the non-master key) is the person whose edit list we are editing.

  • This does not follow the convention of assuming that :uid is always referring to the subject.
  • This also does not allow for situations where an admin with a non-master token wants to edit a user's follow list (the API will always only allow them to edit their own list

The API should be: /api/v2/users/:uid/follow/:targetUid where:

  • _uid is the calling user (for permissions checking and so on)
  • uid is the user whose follow list you are editing
  • targetUid is the user you are (un)following
@julianlam julianlam added the bug label Jul 14, 2020
@julianlam julianlam self-assigned this Jul 14, 2020
@julianlam
Copy link
Member Author

Crud, forgot about this when v3 got implemented 😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant