package.json resolutions entry breaks pnpm

[braco]

https://github.com/NodeBB/NodeBB/blob/b6dbe1a6d68d9ea0fd9ee9681b2955a2efc2523c/install/package.json#L177C1-L179

3.813  ERR_PNPM_INVALID_OVERRIDES_SELECTOR  Cannot parse the "*/jquery" selector in pnpm.overrides

It seems like resolutions is yarn only, and npm's equivalent is overrides?

and I think the point of that entry is to make sure all dependencies have the same version of jquery, but I believe this is covered by just using "jquery", which would be more compatibile.

[julianlam]

The directive was added purely to fix an issue on yarn where the wrong jQuery plugin versions were installed. I think that's why it's */jquery.

If pnpm doesn't crash, that's fine. It probably installs the proper versions like npm does.

[julianlam]

I'm not entirely sure if we still need that directive, so it's worth checking on yarn to see.

[julianlam]

See #10877

[braco]

Ahh thanks.

It causes pnpm initialization to abort.

 > [nodebb builder 6/9] RUN corepack use pnpm@*:                                                                                                                                                              
1.264 Installing pnpm@8.14.0 in the project...
2.355 
3.813  ERR_PNPM_INVALID_OVERRIDES_SELECTOR  Cannot parse the "*/jquery" selector in pnpm.overrides
------
failed to solve: process "/bin/sh -c corepack use pnpm@*" did not complete successfully: exit code: 1
(base) 

If I remember correctly, "*/jquery" is equivalent to "jquery", so wondering if that specific format is necessary. I just looked, the documentation around that isn't very good. I believe the globs were there to cover sub packages with parents like "foo/**/bar"

For now I'm removing the entry from package.json so build works:
jq 'del(.resolutions)' package.json | sponge package.json