Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Leakage #2

Open
personal-coding opened this issue Dec 7, 2019 · 0 comments
Open

Data Leakage #2

personal-coding opened this issue Dec 7, 2019 · 0 comments

Comments

@personal-coding
Copy link

personal-coding commented Dec 7, 2019

Luke,

Your random forest is using a randomized train / test split. Your technical indicators embed prior day information into the calculations, which is leaking data into your randomized splits. Your reference [10] paper has this same issue (https://www.reddit.com/r/algotrading/comments/cv83yh/overfitting).

For time series analysis, you should not use randomized splits, as that is how not data would be received in a real environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant