Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add an option to disable ripple effect on buttons. #367

Open
mld9401 opened this issue Dec 4, 2023 · 2 comments
Open

[FEATURE] Add an option to disable ripple effect on buttons. #367

mld9401 opened this issue Dec 4, 2023 · 2 comments
Labels
enhancement New feature or request feature

Comments

@mld9401
Copy link

mld9401 commented Dec 4, 2023

Describe the feature

It would be great if you could add an option to disable ripple effect while clicking a button.

Why would it be useful to add?

Sometimes the ripple effect is just annoying.

Example(s)

Here is an exemple of onClick ripple effect.

material-button

Additional context

I remember that DotOS (Android 11) didn't have the ripple animation, maybe that could help you.

@mld9401 mld9401 added enhancement New feature or request feature labels Dec 4, 2023
@mld9401 mld9401 changed the title Add an option to disable ripple effect on buttons. [FEATURE] Add an option to disable ripple effect on buttons. Dec 4, 2023
@Mahmud0808
Copy link
Owner

It is indeed possible to remove ripple effect. But without ripple effect you won't know if you actually clicked on the area you intended to or you missed it. So it is important imo.

@mld9401
Copy link
Author

mld9401 commented Dec 19, 2023

I think the ripple effect color is slightly different from the button color so even without ripple animation we can know if we clicked the intended area. I don't know if it's possible to replace the animation by a plain color just like it was before the introducing of the ripple effect on android 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

No branches or pull requests

2 participants