Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synccit custom URL #3122

Open
RubenNL opened this issue Feb 12, 2020 · 3 comments · May be fixed by #3138
Open

Synccit custom URL #3122

RubenNL opened this issue Feb 12, 2020 · 3 comments · May be fixed by #3138
Labels
Feature Request This issue is requesting a feature to be added to Slide. Good First Issue This issue is perfect for you if you are new to Slide.

Comments

@RubenNL
Copy link
Contributor

RubenNL commented Feb 12, 2020

Slide version:6.2.2
Android version:8.1.0

I run my own synccit server, on a custom URL. I have no experience with java, but i have found the url in the code, its at https://github.com/ccrama/Slide/blob/0541b746f09cc4ee61f2957e466840a568209015/app/src/main/java/me/ccrama/redditslide/Synccit/SynccitTask.java#L16.

Is it possible to make this a setting?
@Alexendoo Alexendoo added Feature Request This issue is requesting a feature to be added to Slide. Good First Issue This issue is perfect for you if you are new to Slide. labels Feb 12, 2020
@Alexendoo Alexendoo changed the title SUGGESTION: Synccit custom URL Synccit custom URL Feb 12, 2020
@Alexendoo
Copy link
Member

Alexendoo commented Feb 12, 2020 •
edited

Yes, that is certainly possible. There'd need to be a new method in SynccitTask.java called getEndpoint or something along those lines. They'd work the same way as the current getUsername etc

edit: and a corresponding entry in the settings menu

@RubenNL RubenNL linked a pull request Mar 11, 2020 that will close this issue
Open
@RubenNL
Copy link
Contributor Author

RubenNL commented Mar 11, 2020

I wasn't able to create a getUrl function or something, because it had to be called on creation of the HttpPostTask class.

@Alexendoo Alexendoo linked a pull request Mar 11, 2020 that will close this issue
custom synccit url option #3122 #3138
Open
@kritipchakrabarti
Copy link

@Alexendoo

I want to work on this issue. This is going to be my first proper open-source contribution. I need help from the members of this project. I am really looking forward to contributing to this. Please tell me more about the issue and tell me if there are some other groups or servers where I can join and get familiar with the codebase by discussing with the members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request This issue is requesting a feature to be added to Slide. Good First Issue This issue is perfect for you if you are new to Slide.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

custom synccit url option #3122 RubenNL/Slide
3 participants
@Alexendoo @RubenNL @kritipchakrabarti