Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Color Primary Light Theme" is no longer applied to the floating action bar, despite the subtitle in the settings #1519

Open
3 tasks done
SuperStormer opened this issue Jul 11, 2023 · 1 comment
Labels
type: possible bug Issues that seem to be a bug, but haven't been confirmed yet

Comments

@SuperStormer
Copy link

SuperStormer commented Jul 11, 2023

Checklist

  • I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.
  • If the bug only occurs with a certain link, post, image..., I will include the URL.

App version

6.0.2

Where did you get the app from

Other

Android version

13

Device model

No response

First occurred

yesterday

Steps to reproduce

  1. Open Infinity and note the color of the FAB
  2. Go to the "Customize Theme" page for your current theme
  3. Observe that "Color Primary Light Theme" is no longer the color used for the FAB, but that it is instead the "Color Accent" that is used

Example post, link, markdown...

No response

Expected behaviour

Use the "Color Primary Light Theme" for the FAB, or have the subtitle match the current behavior

Current behaviour

Use the "Color Accent" for the FAB

Screenshots ![Screenshot_20230711_021333_Infinity](https://github.com/Docile-Alligator/Infinity-For-Reddit/assets/41648788/bf63449d-9e2b-43cd-bb15-cc2b467b7ee9)

Screenshot_20230711_021324_Infinity

Logs

No response

@SuperStormer SuperStormer added the type: possible bug Issues that seem to be a bug, but haven't been confirmed yet label Jul 11, 2023
@SuperStormer
Copy link
Author

SuperStormer commented Jul 11, 2023

Related issue: #1344
I believe the current issue is the cause of the linked issue, which still occured on the current release when I imported my settings from an old version (don't remember which) to 6.0.2. The theme in question.


It looks like the FAB's coloration was changed in 8a6eb8e and c5d4ac6


The two obvious ways to fix this (at least to me) would be to removing FAB from the "Color Primary Light Theme" subtitle, or to change the FAB color back to "Color Primary Light Theme".

Here is my kinda biased opinion in support of the latter option: For a dark theme, "Color Accent" has to be a light color—otherwise, the headings on the settings pages would be unreadable, and likely other text using the accent color as the text color. This means that dark themes like Dracula and White Amoled which formerly had a dark colored FAB have a light colored one now, which IMO seems counterproductive for a dark theme (granted, their old colors lacked contrast against the post backgrounds, but that's a different issue). Of course, this is a bit of a https://xkcd.com/1172/ moment, so I would understand if you don't change it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: possible bug Issues that seem to be a bug, but haven't been confirmed yet
Projects
None yet
Development

No branches or pull requests

1 participant