Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose daily calories calendar to math #73811

Merged
merged 5 commits into from
May 16, 2024

Conversation

GuardianDll
Copy link
Contributor

Summary

None

Purpose of change

json power

Describe the solution

make a math function to return value from calorie calendar, thanks Andrei8 for their help

Testing

Compiled, played a little with it
image

Additional context

I am a bit worried to touch commit history because of branch update, so i'd ask to squash the PR if possible

@IdleSol
Copy link

IdleSol commented May 15, 2024

If you can, add two more boxes:

  • Total
  • Average consumption per day for the last week (or all time)

Off topic, would this be for vitamins?

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels May 15, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @andrei8l

src/talker.h Outdated Show resolved Hide resolved
src/talker_avatar.cpp Outdated Show resolved Hide resolved
src/talker_avatar.h Outdated Show resolved Hide resolved
@GuardianDll
Copy link
Contributor Author

GuardianDll commented May 15, 2024

Total

total of what? Nevertheless, one could make a simple jmath to do the same, the result would be equal

There is no such thing for vitamins as far as i know, so there is nothing for me to hook to

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 15, 2024
@IdleSol
Copy link

IdleSol commented May 15, 2024

total of what?

Total calories consumed for the entire period. Is this list limited to 30 days? Then for 30 days.

Oh, and if I'm being brazen, then:
pict

And perhaps we should change the format of the calorie display? 12000 -> 12 000

@GuardianDll
Copy link
Contributor Author

oh, this screenshot is just showcase of the funciton, this PR do not add such UI because the way it works is too ugly for my taste

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 15, 2024
@IdleSol
Copy link

IdleSol commented May 15, 2024

Then I'll hope someone will take on the UI for this feature.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 16, 2024
@dseguin dseguin merged commit a2efbb9 into CleverRaven:master May 16, 2024
26 checks passed
@GuardianDll GuardianDll deleted the calories_daily branch May 17, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants