Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistent type of OperationStatusResult.percentComplete #832

Closed
4 tasks done
Tracked by #1356
Alancere opened this issue May 14, 2024 · 2 comments · Fixed by #860
Closed
4 tasks done
Tracked by #1356

[Bug]: Inconsistent type of OperationStatusResult.percentComplete #832

Alancere opened this issue May 14, 2024 · 2 comments · Fixed by #860
Assignees
Labels
bug Something isn't working needs-area
Milestone

Comments

@Alancere
Copy link
Member

Describe the bug

go sdk two different results:
image

Reproduction

tsp: https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/common-types/types.tsp#L220

spec common-type: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v3/types.json#L439

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@Alancere Alancere added bug Something isn't working MPG Impact labels May 14, 2024
@markcowl markcowl added this to the [2024] June milestone May 14, 2024
@tadelesh
Copy link
Member

cc: @allenjzhang

@allenjzhang
Copy link
Member

Per ARM RPC guide line, it would be float64 (double). https://github.com/Azure/azure-resource-manager-rpc/blob/8231d7df51aec87e6ccb5bcc04478136758b0a4c/v1.0/async-api-reference.md?plain=1#L164

github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
fix [#832](#832)

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants