Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to express example and title node from swagger in tsp #289

Closed
tadelesh opened this issue Feb 22, 2024 · 2 comments · Fixed by #813
Closed

How to express example and title node from swagger in tsp #289

tadelesh opened this issue Feb 22, 2024 · 2 comments · Fixed by #813
Assignees
@timotheeguerin
Labels
bug Something isn't working external:mgmt
Milestone
[2024] June

Comments

@tadelesh
Copy link
Member

Title example: https://github.com/Azure/azure-rest-api-specs-pr/blob/69142cc803bd9e4bbe0737cb0af1e25db2cc2f63/specification/hdinsight/resource-manager/Microsoft.HDInsight/stable/2024-05-01/hdinsight.json#L1574
Example example: https://github.com/Azure/azure-rest-api-specs-pr/blob/69142cc803bd9e4bbe0737cb0af1e25db2cc2f63/specification/hdinsight/resource-manager/Microsoft.HDInsight/stable/2024-05-01/hdinsight.json#L1675
@timotheeguerin
Copy link
Member

@summary is the way to do title but looks like we are not respecting that in autorest emitter.

https://azure.github.io/typespec-azure/playground?c=QHN1bW1hcnkoIlRpdGxlIGlzIGhlcmUiKQptb2RlbCBGT28ge30%3D&e=%40typespec%2Fopenapi3&options=%7B%7D

@timotheeguerin
Copy link
Member

timotheeguerin commented Feb 22, 2024 •
edited

@example is not supported today we have an implementation issue for it

@markcowl markcowl assigned markcowl and unassigned markcowl Feb 22, 2024
@markcowl markcowl added this to the Backlog milestone Feb 22, 2024
@markcowl markcowl added the bug Something isn't working label Feb 22, 2024
@markcowl markcowl modified the milestones: Backlog, [2024] May Feb 22, 2024
@markcowl markcowl modified the milestones: [2024] May, [2024] June Apr 6, 2024
@timotheeguerin timotheeguerin self-assigned this May 9, 2024
@timotheeguerin timotheeguerin mentioned this issue May 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
@timotheeguerin @markcowl
@summary sets the title of definitions (#813)
81d679f 
fix [#289](#289)

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
bug Something isn't working external:mgmt
Projects
None yet
Milestone
[2024] June
Development

Successfully merging a pull request may close this issue.

@summary sets the title of definitions timotheeguerin/typespec-azure
4 participants
@timotheeguerin @markcowl @tadelesh @ArthurMa1978