Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure.Core linter rule to encourage open union for discriminator #97

Closed
Tracked by #269
markcowl opened this issue Jan 8, 2024 · 1 comment · Fixed by #693
Closed
Tracked by #269

Add Azure.Core linter rule to encourage open union for discriminator #97

markcowl opened this issue Jan 8, 2024 · 1 comment · Fixed by #693
Assignees
@timotheeguerin
Milestone
[2024] June

Comments

@markcowl
Copy link
Member

markcowl commented Jan 8, 2024

Implementation Issue for microsoft/typespec#2589

  • Add a linting rule that emits a warning if the discriminator property is not defined in the base type as an open string union
@markcowl markcowl mentioned this issue Jan 8, 2024
Closed
@markcowl markcowl self-assigned this Jan 11, 2024
@markcowl
Copy link
Member Author

@markcowl talk to laurent about timing

@markcowl markcowl added this to the [2024] March milestone Feb 9, 2024
@markcowl markcowl removed their assignment Feb 9, 2024
@markcowl markcowl mentioned this issue Feb 15, 2024
Open
@markcowl markcowl modified the milestones: [2024] March, [2024] April Mar 11, 2024
@markcowl markcowl modified the milestones: [2024] April, [2024] May Apr 6, 2024
@timotheeguerin timotheeguerin self-assigned this Apr 18, 2024
@timotheeguerin timotheeguerin mentioned this issue Apr 18, 2024
Merged
@markcowl markcowl modified the milestones: [2024] May, [2024] June May 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 3, 2024
@timotheeguerin
Add no-string-discriminator linter rule (#693)
9b7a6a2 
fix [#97](#97) add linter
rule to recommend the discriminator property to be explicitly defined as
an extensible union
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
None yet
Projects
None yet
Milestone
[2024] June
Development

Successfully merging a pull request may close this issue.

Add no-string-discriminator linter rule timotheeguerin/typespec-azure
2 participants
@timotheeguerin @markcowl