[BUG] SLES 15 SP5 - Deploy control plane - Modification's required

[amach4]

I've installed a new deployer based on the SLES 15 SP5 PAYG based image.

Note: Please note from my POV it is not required to distinguish between different SLE 15 service pack versions.

For a successful deployment of the control plane I've modified two files:

1 - "configure_deployer.sh" bash script:

--- sap-automation-orig/deploy/scripts/configure_deployer.sh 2024-03-04 08:06:13.344162660 +0000
+++ sap-automation/deploy/scripts/configure_deployer.sh 2024-02-27 15:37:29.561035793 +0000

@@ -292,10 +292,10 @@
     error "Unsupported distro: ${distro_name_version} at this time."
     exit 1
 fi
-if [ "$(get_distro_version)" == "15.5" ]; then
-    error "Unsupported distro: ${distro_name_version} at this time."
-    exit 1
-fi
+#if [ "$(get_distro_version)" == "15.5" ]; then
+#    error "Unsupported distro: ${distro_name_version} at this time."
+#    exit 1
+#fi

---

2 - "configure_deployer.sh.tmpl" Terraform module:

--- sap-automation-orig/deploy/terraform/terraform-units/modules/sap_deployer/templates/configure_deployer.sh.tmpl 2024-03-04 08:06:13.363162854 +0000
+++ sap-automation/deploy/terraform/terraform-units/modules/sap_deployer/templates/configure_deployer.sh.tmpl 2024-02-28 09:49:55.802086636 +0000

@@ -300,10 +300,10 @@
         error "Unsupported distro: $${distro_name_version} at this time."
         exit 1
     fi
-    if [ "$(get_distro_version)" == "15.5" ]; then
-        error "Unsupported distro: $${distro_name_version} at this time."
-        exit 1
-    fi
+  #  if [ "$(get_distro_version)" == "15.5" ]; then
+  #      error "Unsupported distro: $${distro_name_version} at this time."
+  #      exit 1
+  #  fi
 
 
     echo "Set ansible version for specific distros"
@@ -468,7 +468,7 @@
         sudo apt autoremove -y
         sudo apt update -y
       fi
-      if [ "$(get_distro_version)" == "15.3" ]; then
+      if [ "$(get_distro_version)" == "15.5" ]; then
         set +o errexit
         sudo zypper rm -y --clean-deps azure-cli
         set -o errexit

---

Note:

Please note it is NOT required to distinguish between different SLE 15 service pack versions to mark the SLE 15 service pack as unsupported and also for uninstalling the Azure CLI:

File: "sap-automation/deploy/scripts/configure_deployer.sh"

291 if [ "$(get_distro_version)" == "15.4" ]; then
292     error "Unsupported distro: ${distro_name_version} at this time."
293     exit 1 
294 fi    
295 if [ "$(get_distro_version)" == "15.5" ]; then
296     error "Unsupported distro: ${distro_name_version} at this time."
297     exit 1
298 fi    


# Uninstall Azure CLI - For some platforms

478   if [ "$(get_distro_version)" == "15.3" ]; then
479       set +o errexit
480       sudo zypper rm -y --clean-deps azure-cli
481       set -o errexit
482   fi 
483   if [ "$(get_distro_version)" == "15.4" ]; then
484       set +o errexit
485       sudo zypper rm -y --clean-deps azure-cli
486       set -o errexit
487   fi
488   if [ "$(get_distro_version)" == "15.5" ]; then
489       set +o errexit
490       sudo zypper rm -y --clean-deps azure-cli
491       set -o errexit 
492   fi  

---

File: "sap-automation/deploy/terraform/terraform-units/modules/sap_deployer/templates/configure_deployer.sh.tmpl"

299     if [ "$(get_distro_version)" == "15.4" ]; then
300         error "Unsupported distro: $${distro_name_version} at this time."
301         exit 1
302     fi  
303     if [ "$(get_distro_version)" == "15.5" ]; then
304         error "Unsupported distro: $${distro_name_version} at this time."
305         exit 1
306     fi


471       if [ "$(get_distro_version)" == "15.3" ]; then
472         set +o errexit
473         sudo zypper rm -y --clean-deps azure-cli
474         set -o errexit
475       fi 

Thank you