Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1ES] Migrate Diagnostic Events to Azure.Data.Tables #10167

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

[1ES] Migrate Diagnostic Events to Azure.Data.Tables #10167

wants to merge 16 commits into from

Conversation

cjaliaga
Copy link
Member

This PR migrates the Diagnostic Events to use Azure.Data.Tables from Microsoft.Azure.Cosmos.Table

resolves #10165

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR - TODO
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@cjaliaga cjaliaga added the 1es 1 engineering system label May 15, 2024
@cjaliaga cjaliaga force-pushed the cjaliaga/migrate-azure-data-tables branch from e5eda2c to bde1976 Compare May 15, 2024 18:57
@cjaliaga
Copy link
Member Author

deps.json unit test:

IMPORTANT: The dependencies in WebHost have changed and MUST be reviewed before proceeding. Please follow up with brettsam, fabiocav or mathewc for approval.


Previous file: D:\a_work\1\s\out\bin\WebJobs.Script.Tests\debug\Microsoft.Azure.WebJobs.Script.WebHost.deps.json
New file:      D:\a_work\1\s\out\bin\WebJobs.Script.WebHost\debug\Microsoft.Azure.WebJobs.Script.WebHost.deps.json


Changed:


Removed:


Added:
- Azure.Data.Tables.dll: 12.8.3.0/12.800.324.10602

@cjaliaga cjaliaga marked this pull request as ready for review May 28, 2024 17:01
@cjaliaga cjaliaga requested review from fabiocav, mathewc and a team as code owners May 28, 2024 17:01
jviau
jviau reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just @brettsam's comment regarding checking table exists before creation to minimize telemetry. Also wondering when we can remove the deprecated Microsoft.Azure.Cosmos.Table package.

src/WebJobs.Script.WebHost/WebJobs.Script.WebHost.csproj Show resolved Hide resolved
@cjaliaga
Copy link
Member Author

Looks good. Just @brettsam's comment regarding checking table exists before creation to minimize telemetry.

The Azure.Data.Tables SDK after 12.7.0 seems to have that issue resolved. I'm double checking that's actually the case: Azure/azure-sdk-for-net#30849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettsam brettsam brettsam left review comments

@jviau jviau jviau approved these changes

@fabiocav fabiocav Awaiting requested review from fabiocav fabiocav is a code owner

@mathewc mathewc Awaiting requested review from mathewc mathewc is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
1es 1 engineering system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Diagnostic Events to Azure.Data.Tables
3 participants
@cjaliaga @brettsam @jviau