-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mysql
with mysql2
#19361
Comments
mysql
with mysql2
I'd rather not try to support both if the end result is the same, so I'm hijacking this issue as a reminder to replace |
Please don't forget about this, the mysql error logs are getting ridiculous. Thanks for all your hard work. |
+1 for this feature |
I can reveal that I have been using Directus with mysql2 for the past year now in three production environments and have had zero issues so far, if anyone was wondering about possible issues. I apply it via a hotfix overwrite of some directus files |
How are you applying the hotfix? Are you manually editing files in node_modules? |
Yeh, from the start I have been using Directus via npm install, since there are so many hot-fixes I need just for different reasons. Here is my full set of hot fixes, most are done for performance optimisations that I have made PRs for, but they are not in Directus yet. So if you only use mysql, then you should be able to use this: Unzip into your root Directus folder (same as where extensions folder is) then run |
Nice one thanks will take a look! |
A better way to do this is to just run this bash command after install to find/replace (can even execute inside Docker):
Also set |
this issue gains importance. you cannot start directus with actual versions of mysql8.... |
Try this solution. It helped me run the container. But this issue is really becoming important. |
+1 for getting this fixed. Not only is using |
Based on the suggestion by @fire015, I build this minimal Dockerfile for those using docker.
|
Describe the Bug
Changing DB_CLIENT from
mysql
tomysql2
and installing themysql2
package leads to an error about unsupported database client.Though I understand this is not a bug, I did find in the code that both Knex and the Directus schema code support mysql2 so wonder if this was just missed?
To Reproduce
Ad in in description switch to
mysql2
Directus Version
10.5.2
Hosting Strategy
Self-Hosted (Docker Image)
The text was updated successfully, but these errors were encountered: