Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Can provide an "afterBundleCommand" hook function? #9767

Open
muwoo opened this issue May 13, 2024 · 4 comments
Open

[feat] Can provide an "afterBundleCommand" hook function? #9767

muwoo opened this issue May 13, 2024 · 4 comments

Comments

@muwoo
Copy link

muwoo commented May 13, 2024

Describe the problem

Sometimes, I need to run some custom scripts after building the installer application ({appname}-setup.exe) and before generating the update package(such as setup.nsis.zip or setup.nsis.zip.sign).

This is because I need to manually sign the {appname}-setup.exe file, and without this afterBundleCommand hook, I won't be able to complete this before generating the update package.

Describe the solution you'd like

Can you provide a hook "afterBundleCommand" to execute after the installer application is generated?

Alternatively, are there any alternative solutions?

Thanks alot!

Additional context

No response

@muwoo muwoo changed the title Can provide an "afterBundleCommand" hook function? [feat] [feat] Can provide an "afterBundleCommand" hook function? May 13, 2024
@amrbashir
Copy link
Member

how and why do you need to manually sign installer? if you have setup the signing configurations correctly, we sign the installer for you.

@muwoo
Copy link
Author

muwoo commented May 13, 2024

@amrbashir Thank you very much for your reply!

I configured it correctly, and I see that tauri will sign the packaged exe application, but I still need to sign the generated NSIS setup.exe installation package.

But I'm not sure if Tauri will continue to sign this setup.exe. If it can be signed, then I don't need this requirement, if not, then I want to be able to customize the script to continue signing setup.exe after the bundle produces setup.exe.

@amrbashir
Copy link
Member

It does sign the -setup.exe file, can you show the ouput of tauiri build --verbose

@muwoo
Copy link
Author

muwoo commented May 13, 2024

It does sign the -setup.exe file, can you show the ouput of tauiri build --verbose

I know, thank you very much for your reply, but I still wish Tauri could add more hooks to the build process, similar to Electron, so the developer's freedom would be much better.
For example, in electron-builder, we can set these hooks:

beforePack
afterPack
afterSign
afterAllArtifactBuild
onNodeModuleFile
AfterPackContext
BuildResult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants