codec(ticdc): simple decoder set the table id on handle key only event and make consumer more strict on the ts order #11089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11089 +/- ##
================================================
+ Coverage 57.4786% 57.5995% +0.1209%
================================================
Files 851 854 +3
Lines 125511 126145 +634
================================================
+ Hits 72142 72659 +517
- Misses 47998 48100 +102
- Partials 5371 5386 +15 |
|
/retest |
ti-chi-bot
bot
added
size/L
3AceShowHand
changed the title
|
/test dm-integration-test |
|
/retest |
|
/test dm-integration-test |
|
/retest |
CharlesCheung96
approved these changes
May 16, 2024
asddongmen
reviewed
May 16, 2024
asddongmen
approved these changes
May 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
3AceShowHand
added a commit
to 3AceShowHand/tiflow
that referenced
this pull request
May 20, 2024
…nly event and make consumer more strict on the ts order (pingcap#11089)" This reverts commit f760b26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11088
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note