feat/docs(editorconfig): add support for spelling_language #28638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpanders
reviewed
May 4, 2024
|
Can you please also update |
|
I encountered problems with the Should I adapt |
The `test_case` method presumed that all options set by editorconfig
were *buffer-local* so it called `nvim_get_option_value` with `{ buf = 0
}` even for *window-local* options such as `spell`.
Now `nvim_get_option_info2` is used to get the scope of the option. This
scope can be: "global", "win" or "buf".
zeertzjq
reviewed
May 7, 2024
|
Looks like I forgot to add some parameters. It's weird because when I ran |
zeertzjq
reviewed
May 7, 2024
zeertzjq
reviewed
May 7, 2024
A *GOOD* example of spelling_language is en-US. ('-' must be used as a
separator)
A *BAD* example of spelling_language is en/US or en_US.
justinmk
reviewed
May 7, 2024
| spelling_language = en | ||
|
|
||
| [long_spelling_language.txt] | ||
| spelling_language = en-US |
There was a problem hiding this comment.
probably should test something other than the default
sus-domesticus
force-pushed
the
feat/editorconfig
branch
from
c63c911
to
af67eb2
Compare
These were changed to use something other than the default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #28626.
For the other editorconfig properties it's easier to check for validity since they are either a number or part of an enum with few elements. The problem for
spelling_languageis that it is part of a greater enum since it's a concatenation of a ISO 639 language code and an optional ISO 3166 territory identifier.For now the code only checks that the value provided in
spelling_languageis of the format [a-z][a-z] or [a-z][a-z]-[a-z][a-z] (regex), but it doesn't check whether it is a valid ISO639/ISO3166 code and thus when inputting an invalid value thespelllangoption is also set to an unknown language (this results in a prompt asking you to download the unknown language and then failing and continuing if accepted).