Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual prevalence entry v2 proposal #1836

Open
octern opened this issue Apr 16, 2023 · 1 comment
Open

Manual prevalence entry v2 proposal #1836

octern opened this issue Apr 16, 2023 · 1 comment
Labels
type: enhancement New feature or request

Comments

@octern
Copy link
Contributor

octern commented Apr 16, 2023 •
edited

Goal of this proposal

Proposed changes

  • Ensure that the useManualPrevalance field in the URL doesn't do anything (currently it's optional, but if present and set to 0 it forces a geographic lookup)
  • Maintain the existing entry fields from the previous update (Manual prevalence entry v1 proposal #1826 ) but hide all of them except for the prevalence field.
  • Make them visible again if the user checks an "advanced mode" box
  • Provide a slider that can be used to set a COVID prevalence between 0.00 and 5.00%. This updates the value in the still-visible prevalence field. The user can also type values into that field manually.
  • The slider should have a few presets that it can snap to, labeled "low", "medium", "high", and "surge". They should be appropriately color-coded. We should be able to edit what actual numbers they correspond to.
  • The images below show crude renderings of what the site could look like. Note that we'd move to a 1-column layout, replacing the current 2-column layout.

image
image
@octern octern added the type: enhancement New feature or request label Apr 16, 2023
@CloudByteKS
Copy link
Collaborator

CloudByteKS commented Apr 25, 2023 •
edited

Leaving some notes based on our previous conversation.

  • Remove the warning field "Since our system doesn't yet have vaccine data for your region, we aren't able to provide a way for you to adjust your score based on whether or not the person you're seeing is vaccinated."
  • Make the "adjusted prevalence" value manually adjustable if the user chooses to manually adjust it, or default it back to the calculated value, which is weekly new cases divided by total population.
  • The slider proposed in the UI changes will be affecting the value of the weekly-new-cases field as that is the main input.
  • Ignore the "advanced mode" hide / unhide checkbox feature for now. We can revisit this later if you decide to add it back in.

schultz96 added a commit to CloudByteKS/microCOVID that referenced this issue Jun 9, 2023
@schultz96
microCOVID#1836 add + update slider with preset buttons and labels di…
2bf2af0 
…sappear when on mobile to avoid collision
octern pushed a commit that referenced this issue Jun 24, 2023
@CloudByteKS @schultz96
Issue 1836 - Manual prevalence entry v2 proposal (#1838)
a44193a 
* issue-1826 changes

* issue-1826 pull-1837 feedback updates

* issue-1836 v2 changes

* revert yarn.lock

* revert yarn.lock back

* remove warnings potentially causing netlify

* add styling libraries for mui

* wrap in ThemeProvider

* remove dependency mui and use a different library

* update yarn.lock after fresh install

* rm yarn & regenerate

* rm yarn

* revert again...

* reinstall mui

* issue-1836 updated based on feedback

* * Please change the step value for the slider from 100 to 10 so it's smoother
* If the number in the total population box is changed from 100,000, then the label for the box above it should change to "total weekly new cases"
* At mobile screen width, the explanatory labels on the slider no longer work. Please set them to wrap properly.
* Please send the instructions on how to edit the presets and their labels.
* See if you can fix #1839 (text boxes are unusable and widths between phone and desktop)
* Change the text in the pink bar from "Step 1: Characterize community infection" to "Step 1: Enter COVID rate"
* Change the instructions to:
Use the slider or text box to enter weekly new COVID cases per 100,000 people in your area. You can also estimate whether cases are relatively low or high and use the preset options on the slider.
In the US you can look up weekly new cases on covidactnow.org by clicking your state on the map, and then your county. The first number on the screen is "weekly new reported cases per 100k"

* fix typo in readme.md

* fix step count showing decimals on slider

* #1836 add + update slider with preset buttons and labels disappear when on mobile to avoid collision

* eslint fixes

* make buttons vertical instead of horizontal

* increase step count to decrease lag and change text to include link (took out of <Trans> element to be able to insert URL into text)

---------

Co-authored-by: kenny96 <kblaze1996@gmail.com>
octern pushed a commit that referenced this issue Jul 10, 2023
@CloudByteKS @schultz96
issue-1836 BUG FIX (#1845)
360b70c 
* issue-1826 changes

* issue-1826 pull-1837 feedback updates

* issue-1836 v2 changes

* revert yarn.lock

* revert yarn.lock back

* remove warnings potentially causing netlify

* add styling libraries for mui

* wrap in ThemeProvider

* remove dependency mui and use a different library

* update yarn.lock after fresh install

* rm yarn & regenerate

* rm yarn

* revert again...

* reinstall mui

* issue-1836 updated based on feedback

* * Please change the step value for the slider from 100 to 10 so it's smoother
* If the number in the total population box is changed from 100,000, then the label for the box above it should change to "total weekly new cases"
* At mobile screen width, the explanatory labels on the slider no longer work. Please set them to wrap properly.
* Please send the instructions on how to edit the presets and their labels.
* See if you can fix #1839 (text boxes are unusable and widths between phone and desktop)
* Change the text in the pink bar from "Step 1: Characterize community infection" to "Step 1: Enter COVID rate"
* Change the instructions to:
Use the slider or text box to enter weekly new COVID cases per 100,000 people in your area. You can also estimate whether cases are relatively low or high and use the preset options on the slider.
In the US you can look up weekly new cases on covidactnow.org by clicking your state on the map, and then your county. The first number on the screen is "weekly new reported cases per 100k"

* fix typo in readme.md

* fix step count showing decimals on slider

* #1836 add + update slider with preset buttons and labels disappear when on mobile to avoid collision

* eslint fixes

* make buttons vertical instead of horizontal

* increase step count to decrease lag and change text to include link (took out of <Trans> element to be able to insert URL into text)

* fix label formatting issue preventing user from being able to click weekly new cases text field

---------

Co-authored-by: kenny96 <kblaze1996@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octern @CloudByteKS