fix: Fix file not found error with individual recipe export/download. #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itable test. Split temporary_zip_path into temporary_zip_path and unlinking_temporary_zip_path.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michael-genson
requested changes
May 17, 2024
michael-genson
requested changes
May 20, 2024
…clean up the temporary assets.
michael-genson
approved these changes
May 20, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary_zip_pathintotemporary_zip_pathandunlinking_temporary_zip_path.What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR fixes the issue that was preventing the recipe download and the
/api/recipes/{slug}/exports/zipendpoint more generally from working. As described in #3095, it would fail with a file not found. This was caused by the file being deleted before the Response read the file from the filesystem.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3095
Special notes for your reviewer:
(fill-in or delete this section)
I created a version of
temporary_zip_paththat doesn't unlink when the view completes and added background task to the Response to clean up the file that is run after the Response is delivered to the client.Renamed the original
temporary_zip_pathtounlinking_temporary_zip_fileand updated references to point to the new name. This seemed like clearer naming given the changes.Testing
test_get_recipe_as_zipthat failed with the error described in [BUG] - Cannot Download Recipe(s) #3095 before the fix, and succeeded afterwards.