Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the SI.Posterior Samples are huge #114

Open
jstockwin opened this issue Jun 13, 2017 · 3 comments
Open

Some of the SI.Posterior Samples are huge #114

jstockwin opened this issue Jun 13, 2017 · 3 comments

Comments

@jstockwin
Copy link
Owner

jstockwin commented Jun 13, 2017

See https://github.com/jstockwin/EpiEstimApp/tree/master/inst/app/datasets/SIPosteriorSamples and note how big the EcuadorRotavirus files for off1W and off1L are. Is this expected?

Tests are currently disabled for off1W, L, and off1L for this reason.

@robin-thompson Do you know if this is expected..?

@jstockwin
Copy link
Owner Author

Note this is probably the same as #66, but last time we were removing that dataset anyway so it wasn't an issue.

@jstockwin jstockwin added this to Critical (S1) in Severity Triage Jun 15, 2017
@jstockwin jstockwin added this to High (P2) in Priority Triage Jun 15, 2017
@jstockwin
Copy link
Owner Author

This happens when there is not much SI data, so it can choose ridiculous params for the distributions, meaning it has to go to very high values of time before the full distribution is small (i.e. max_time = inverse_CDF(0.999)).

This may cause problems, but there's not much we can do, short of lowering the 0.999 tolerance, which is here: https://github.com/annecori/EpiEstim/blob/hackout3/R/coarse2estim.R#L74

@jstockwin
Copy link
Owner Author

OR we can change coarse2estim so that instead of forcing every column to sum to >0.999, stop when the probability that the serial interval is more than t (over all columns) is less than 0.001.

@robin-thompson Is going to work out how to do this.

@jstockwin jstockwin added this to To do in Tasks via automation Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Priority Triage
  
High (P2)
Severity Triage
  
Critical (S1)
Tasks
  
To do
Development

No branches or pull requests

2 participants