Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove the "in English" link from the editions list on a work page? #9253

Open
RayBB opened this issue May 10, 2024 · 9 comments
Open
Assignees
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented May 10, 2024

Having the link that just goes to this page (https://openlibrary.org/languages/eng) and is not useful to patrons as far as I can tell.

Describe the problem that you'd like solved

image

Proposal & Constraints

I think we should convert it to plain text instead of a hyperlink.

Additional context

Stakeholders

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 10, 2024
@stopregionblocking
Copy link

Doesn't this display for every language, not just english? Maybe there's a different function it could be changed to that would be beneficial across languages.

@RayBB
Copy link
Collaborator Author

RayBB commented May 10, 2024

@stopregionblocking it does show for every language. What function do you propose changing it to?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 11, 2024
@mekarpeles
Copy link
Member

I think we just want to remove the link around the language -- not the language text itself. This change seems fine (+1 @mekarpeles , @jimchamp , @scottbarnes )

@mekarpeles mekarpeles added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Good First Issue Easy issue. Good for newcomers. [managed] Affects: Experience Issues relating directly to service design & patrons experience and removed Needs: Lead Needs: Response Issues which require feedback from lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels May 13, 2024
@jainish2222
Copy link

Hello! Could I please work on this issue?

@RayBB
Copy link
Collaborator Author

RayBB commented May 20, 2024

@jainish2222 yes you're assigned. Good luck!

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 21, 2024
@RayBB RayBB removed the Needs: Response Issues which require feedback from lead label May 26, 2024
@hornc
Copy link
Collaborator

hornc commented Jun 3, 2024

I don't see that this is a valuable feature. This is special casing English to be the only language that doesn't get a link.
Searching for books by language doesn't have a great user flow - as far as I can tell the advanced search page doesn't support languages. Language faceting on the other hand seems a lot better, but that supports a slightly different use case.

Improving searching by language, or making the language pages more useful for specific tasks would be better features.

This will add complexity in a way that doesn't seem generlizable If the website is being viewed in German is it still only English that doesn't have a link?

I vote to close this as "not planned"

@cdrini
Copy link
Collaborator

cdrini commented Jun 3, 2024

Oh to clarify I think the proposal is to remove e.g. the "in English" link. So all the "in {language}" links on the editions table, not specifically the English ones!

@hornc
Copy link
Collaborator

hornc commented Jun 3, 2024

Remove the links to all language pages, but keep the text there? I don't see what that adds either. I guess that's why this is confusing.

For the recent work I've been doing on language codes the main way to get to view what languages OL has is by clicking on one of those links and then going back a level to https://openlibrary.org/languages

Language is one of the formal OL types https://openlibrary.org/type/language , removing the link will hide the specific catalog code used e.g. fre for French, which might be useful information for a patron to know. When other type objects are used on the UI, they are linked. Removing the link here would be inconsistent.

@cdrini
Copy link
Collaborator

cdrini commented Jun 3, 2024

The reasoning is I believe that clicking on e.g. "English" leads you to the somewhat empty https://openlibrary.org/languages/eng page. It's kind of a strange way to discover the /languages page as well. I wonder if we should add "Languages" to the Browse dropdown... A lot of people use Open Library to find books in a specific language! Note we do currently also link to /languages from /subjects

Note the current edition e.g. "English" link will still link to /languages/eng (here:
image
)

But we also don't link to the e.g. publisher page from the editions table (which is arguably a more useful page).

I think the ideal UX for me would probably be:

  1. Clicking eg "in English" should filter the editions table for other editions in English.
  2. There should be a "Browse > By Language" option that goes to /languages
    • Likely blocked on a few pieces:
      • The /languages page should be cached, it's rather slow
      • Browse is getting a little long... maybe we can drop "Advanced Search" from here (depending on what analytics says) since we also link to it in the search dropper/search page.
      • We need to fix the bug with large search result set (eg languages:eng) causing solr to timeout.

I think until that larger plan, removing the links seems ok to me, and makes the editions table a little simpler (and also opens the path forward for us to change the behaviour of the link a little more cleanly to filtering the table). But would love to hear others' thoughts as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

6 participants