Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup/convert barcodescanner to use Vue #7615

Open
2 tasks
cdrini opened this issue Mar 9, 2023 · 3 comments · May be fixed by #9217
Open
2 tasks

Cleanup/convert barcodescanner to use Vue #7615

cdrini opened this issue Mar 9, 2023 · 3 comments · May be fixed by #9217
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Barcode Scanner Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Mar 9, 2023 •
edited

This is becoming interactive enough where having it be in Vue would be helpful.

Steps (two separate PRs):

  • Update LazyBookCard so that after it fetches /isbn/..., it fetches https://openlibrary.org/search.json?q=edition_key:OL38222427M&fields=key,author_name in stead of making multiple requests for the author names.
  • Create a new BarcodeScanner Vue component. Most of the helper classes should remain the same and just be moved over (eg OCRScanner). LazyBookCard should be made into a Vue component. OLBarcodeScanner should be made into a vue component. Life the html from barcode-scanner.html, and replace it with a Vue app rendering (eg $:render_component('MergeUI', attrs=attrs))

Stakeholders

@Eds-Dbug
@cdrini cdrini added Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] Priority: 2 Important, as time permits. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Theme: Barcode Scanner labels Mar 9, 2023
@Eds-Dbug
Copy link
Contributor

Eds-Dbug commented Mar 9, 2023

I would like to work on this issue!

@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] and removed Priority: 2 Important, as time permits. [managed] labels Sep 15, 2023
@cdrini cdrini added the Good First Issue Easy issue. Good for newcomers. [managed] label Jan 18, 2024
@Eds-Dbug
Copy link
Contributor

I guess ill have to learn Vue then.

@leanderoudakkertue
Copy link

leanderoudakkertue commented Mar 19, 2024 •
edited

@cdrini
Hi, I noticed there hasn't been any activity for a few months. I would like to give it a try, could you assign me?

@leanderoudakkertue leanderoudakkertue mentioned this issue Apr 2, 2024
Closed
@leanderoudakkertue leanderoudakkertue linked a pull request May 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Barcode Scanner Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Milestone
No milestone
4 participants
@mekarpeles @cdrini @Eds-Dbug @leanderoudakkertue