Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Switching context doesn't invalidate environment variables and requests #3864

Open
1 task done
jobartim44 opened this issue Feb 27, 2024 · 3 comments · May be fixed by #4030
Open
1 task done

[bug]: Switching context doesn't invalidate environment variables and requests #3864

jobartim44 opened this issue Feb 27, 2024 · 3 comments · May be fixed by #4030
Labels
bug Something isn't working need testing Needs to be tested before merging onto production

Comments

@jobartim44
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

When I change my Workspace the environment variables are still set. I use generic variables along my different workspace and collections like <<base_url>> so this is source of mistake if they are not unset.

The same way I would like request tabs to be closed when switching my workspace.

Steps to reproduce

Configure différent workspaces with environment variables having the same name.
Swith workspace, don't select any environment, variables are still set.

Environment

Production

Version

Self-hosted
@jobartim44 jobartim44 added bug Something isn't working need testing Needs to be tested before merging onto production labels Feb 27, 2024
@jobartim44
Copy link
Contributor Author

If we close every tabs, we should have an empty panel. This is not possible at the moment we always need to have an open request atb.

@jobartim44 jobartim44 linked a pull request May 2, 2024 that will close this issue
Open
@nivedin
Copy link
Member

nivedin commented May 15, 2024

If we close every tabs, we should have an empty panel. This is not possible at the moment we always need to have an open request atb.

Thank you for sharing your observation. Could you please provide more insight into the use case for this feature? Understanding its intended purpose will help us address any limitations or consider potential improvements.

@jobartim44
Copy link
Contributor Author

If we close every tabs, we should have an empty panel. This is not possible at the moment we always need to have an open request atb.

Thank you for sharing your observation. Could you please provide more insight into the use case for this feature? Understanding its intended purpose will help us address any limitations or consider potential improvements.

I like to only have opened tabs that related to the current workspace. The easier way is to close every tabs when switching from one workspace to another. But if this action closed every request tabs we should have something to show. It could be an empty panel or tab (watever the way it takes). We could also have quick actions in this 'welcome' tab like creating a new request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need testing Needs to be tested before merging onto production
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switching workspace doesn't invalidate context jobartim44/hoppscotch-switch-workspace
2 participants
@jobartim44 @nivedin