Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cone emitter to particles #6761

Open
QbieShay opened this issue Apr 26, 2023 · 5 comments · May be fixed by godotengine/godot#91973
Open

Add cone emitter to particles #6761

QbieShay opened this issue Apr 26, 2023 · 5 comments · May be fixed by godotengine/godot#91973
Labels
topic:particles topic:shaders

Comments

@QbieShay
Copy link

Describe the project you are working on

VFX

Describe the problem or limitation you are having in your project

There is no way to spawn particles in a cone

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Add a cone emitter with properties for angle of the cone, length of the cone, flatness of the cone (imagine projecting the cone on a plane).

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

See above

If this enhancement will not be used often, can it be worked around with a few lines of script?

Yes, I can script my own emitters. But using custom particle shaders has documented hassle (#6661)

Is there a reason why this should be core and not an add-on in the asset library?

See #6661
@Calinou
Copy link
Member

Calinou commented Apr 26, 2023

Should particles be emitted on the cone surface or within the cone volume?

@QbieShay
Copy link
Author

I suppose, both? I was thinking of the cone volume but both works

@QbieShay
Copy link
Author

I'm thinking maybe it's enough to add a property to the ring emitter for this

@Calinou
Copy link
Member

Calinou commented Apr 26, 2023

I'm thinking maybe it's enough to add a property to the ring emitter for this

Sounds good 🙂

If the ring's top and bottom radius can be changed separately, then you can have a cone (top/bottom radius = 0.0) or anything in between. This would also allow choosing between whether the surface or volume should be used by adjusting the inner ring radius.

@MewPurPur
Copy link

MewPurPur commented May 2, 2023 •
edited

CylinderMesh makes it so setting one of its caps to 0 radius turns it into a cone. For customization's sake and also for consistency, we probably want to implement cones the same way for particles.

@Arnklit Arnklit linked a pull request May 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:particles topic:shaders
Projects
VFX and Techart wishlist
Status: Needs consensus
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cone angle control to particle emission ring shape Arnklit/godot
3 participants
@Calinou @QbieShay @MewPurPur