Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js beta rpg step 23 - code check doesn't accept shorthand margin specification #54849

Closed
hbar1st opened this issue May 16, 2024 · 1 comment
Closed
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@hbar1st
Copy link
Contributor

hbar1st commented May 16, 2024

Describe the Issue

step 23 of the js beta course gives instructions as follows:

Use margins to center it by setting the top margin to 30px, bottom margin to 0px, and the left and right margin to auto.

I attempted to use a shorthand version of a margin css statement but it was not accepted and the hints required that I type in margin-left, margin-right etc. before the code checking would allow me to contine.

This seems like an oversight. Either because the instructions were not clear enough or because the checking is not allowing valid css.

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-javascript-by-building-a-role-playing-game/step-23

Your code

#game {
  max-width: 500px;
  max-height: 400px;
  background-color: #ffffff;
  color: #ffffff;
  margin: 30px, auto, 0px, auto;
  padding: 10px;
}

Expected behavior

The step should either allow using shorthand margin syntax or be explicit in what is required (using margin-top etc).

Screenshots

No response

System

N/A

Additional context

No response

@hbar1st hbar1st added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels May 16, 2024
@gikf
Copy link
Member

gikf commented May 17, 2024

Thank you for reporting this issue.

That notation doesn't use the comma to separate the values 🙂. I've confirmed margin: 30px auto 0px auto will work, and because of that I'm going to close the issue.

If you think we're wrong in closing this issue, please request for it to be reopened and add further clarification.

Thank you and happy coding.

@gikf gikf closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@gikf gikf removed the status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

No branches or pull requests

2 participants