Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in step 4 of js beta review project for building a gradebook app #54826

Closed
hbar1st opened this issue May 16, 2024 · 7 comments · Fixed by #54850
Closed

typo in step 4 of js beta review project for building a gradebook app #54826

hbar1st opened this issue May 16, 2024 · 7 comments · Fixed by #54850
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@hbar1st
Copy link
Contributor

hbar1st commented May 16, 2024

Describe the Issue

When invalid code is submitted to step 4 of the gradebook app review project, a message is shown which has a typo. "Your studentMsg function should return a the correct ..."

Please remove the a

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/review-js-fundamentals-by-building-a-gradebook-app/step-4

Your code

just click submit without typing anything to trigger the error message display

Expected behavior

pls correct the typo

Screenshots

No response

System

N/A

Additional context

No response

@hbar1st hbar1st added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels May 16, 2024
@gikf gikf added first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. new javascript course These are for issues dealing with the new JS curriculum and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels May 16, 2024
@gikf
Copy link
Member

gikf commented May 16, 2024

Thanks for opening this issue.

This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix:

List of files:

  1. https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/review-js-fundamentals-by-building-a-gradebook-app/6626b8dcf5057f896f948440.md

Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.

Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first.

Happy contributing.

@Sayalikukkar
Copy link

Hi @gikf, I am intrested to work on this, Can I start?

@thejon07
Copy link

thejon07 commented May 16, 2024

iam interested to work on this issue

@gikf
Copy link
Member

gikf commented May 16, 2024

Hey @Sayalikukkar, @thejon07

We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.

Issues labelled with help wanted or first timers only are open for contributions.

Please make sure you read our guidelines for contributing. We prioritize contributors following the instructions in our guide. Join us in our chat room or the forum if you need help contributing - our community will be happy to assist you.

@Jaiharishan
Copy link

Hi, can I take up this issue? I am new to open source so looking to start with some small contributions.

@jdwilkin4
Copy link
Contributor

jdwilkin4 commented May 16, 2024

@Jaiharishan

We do not assign issues except to long time contributors and members.

please read through this note here on contributing
#54826 (comment)
thanks

@bhusal-rj
Copy link

@jdwilkin4
I have created a PR #54846 for the issue.
Waiting for your feedback. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
7 participants