Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 1 of RPS project allows for incorrect answers #54814

Closed
jdwilkin4 opened this issue May 15, 2024 · 0 comments · Fixed by #54815
Closed

Step 1 of RPS project allows for incorrect answers #54814

jdwilkin4 opened this issue May 15, 2024 · 0 comments · Fixed by #54815
Assignees
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@jdwilkin4
Copy link
Contributor

jdwilkin4 commented May 15, 2024

Describe the Issue

last test should be updated. The last test for the Rock, Paper, Scissors game review project allows for incorrect answers like this to pass

function getRandomComputerResult() {
  const options = ["Rock", "Paper", "Scissors"];
  return "Paper"
}

The attached PR resolves that.

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/review-dom-manipulation-by-building-a-rock-paper-scissors-game/step-1

Your code

n/a

Expected behavior

n/a

Screenshots

No response

System

  • Device: [e.g. iPhone 6, Laptop]
  • OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]

Additional context

No response

@jdwilkin4 jdwilkin4 added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. new javascript course These are for issues dealing with the new JS curriculum labels May 15, 2024
@jdwilkin4 jdwilkin4 self-assigned this May 15, 2024
@freeCodeCamp freeCodeCamp locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
1 participant