PR Description

NEED HELP

In order to support duplicate search params, the type of paramsMap in RequestModel was changed from Map<String, String> to Map<String, dynamic> which matches with the queryParameters which is accepted by the Uri constructor.

Going through the documentation for Uri class I have found that there are two properties, queryParameters and queryParametersAll of which former supports duplicate query parameters by returning Map<String, List<String>> object. Similar behaviour is also observed in NodeJS [URLSearchParams] where we have urlSearchParams.get and urlSearchParams.getAll.Therefore, all the occurrences of Uri.queryParameters were changed to Uri.queryParametersAll.

The response sent also have query parameters as expected.

This however, breaks all the codegen tests as the earlier expectation was to override query params. Therefore, I have updated the requestModelGet3 to accept query params.

/// GET request model with duplicate query params
const requestModelGet3 = RequestModel(
  id: 'get3',
  url: 'https://api.apidash.dev/country/data?code=US&code=UK',
  method: HTTPVerb.get,
  requestParams: [
    NameValueModel(name: 'code', value: 'IN'),
    NameValueModel(name: 'code', value: 'JP'),
  ],
);

I have fixed the codegen for curl, but will need help to change codegen for other languages/frameworks also.

Related Issues

• Related Issue Can not pass multiple query parameters with same key name #268
• Closes Can not pass multiple query parameters with same key name #268

Checklist

• I have gone through the contributing guide
• I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

• Yes
• No, and this is why: please replace this line with details on why tests have not been included