Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wrap long text when pasting #8026

Merged
merged 6 commits into from
May 21, 2024
Merged

feat: wrap long text when pasting #8026

merged 6 commits into from
May 21, 2024

Conversation

ryan-di
Copy link
Member

@ryan-di ryan-di commented May 17, 2024 •
edited

Builds upon #7999 and closes #8019.

When pasting long texts, they'll get wrapped if their width is more than the lesser of 50% of the scene width and 800 pixels. Additionally, when pasting, the text should be centered to the last viewport position.

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview May 21, 2024 2:32pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview May 21, 2024 2:32pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview May 21, 2024 2:32pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 2:32pm

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.58% (🎯 70%) 51285 / 78196
🔴 Statements 65.58% (🎯 70%) 51285 / 78196
🔴 Functions 66.68% (🎯 68%) 1565 / 2347
🟢 Branches 80.97% (🎯 70%) 6295 / 7774
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/components/App.tsx 69.57% 76.43% 67.87% 69.57% 478-479, 586-595, 694-695, 713-714, 735-795, 798-804, 807-810, 813-889, 892-911, 914-919, 927-937, 939-940, 945-946, 950-952, 966, 973-1234, 1294-1295, 1306-1307, 1335-1337, 1347-1392, 1418, 1428, 1435-1438, 1447-1451, 1482-1483, 1567-1577, 1582-1597, 1601-1648, 1720-1725, 1754-1759, 1762-1792, 1800-1825, 1828-1837, 1840-1952, 1955-1963, 1972-1985, 1988-2014, 2017-2088, 2091-2132, 2184-2185, 2199-2200, 2227-2228, 2232-2233, 2253-2261, 2266-2279, 2285-2286, 2291-2299, 2301-2309, 2321, 2362-2363, 2385-2386, 2393, 2462-2464, 2467-2472, 2477-2478, 2517-2525, 2530-2539, 2577-2578, 2665-2666, 2670, 2673-2674, 2682-2685, 2694-2707, 2713-2716, 2719, 2721-2722, 2729-2730, 2736-2737, 2740-2741, 2749-2750, 2753-2754, 2757-2760, 2771-2779, 2784-2785, 2835-2836, 2850-2856, 2862-2870, 2874-2882, 2886-2887, 2890-2923, 2926-2938, 2949-2950, 2961-2962, 2979-2983, 2987-2990, 2997-2999, 3017-3024, 3027, 3029-3034, 3038-3040, 3061-3062, 3069-3071, 3073-3096, 3122, 3128, 3184-3185, 3202-3204, 3226-3227, 3233-3236, 3242-3323, 3377, 3381, 3416-3417, 3476, 3486-3504, 3507-3513, 3516-3517, 3523-3536, 3622-3623, 3625-3626, 3631-3633, 3641-3642, 3665-3679, 3684-3703, 3755-3756, 3835, 3844-3845, 3847-3854, 3869-3873, 3884-3885, 3888-3892, 3894-3895, 3897-3900, 3925-3926, 3935-3937, 3939, 4022-4025, 4047-4049, 4059-4060, 4062-4082, 4085-4091, 4108-4111, 4117-4120, 4130-4137, 4177-4181, 4185, 4190-4191, 4196-4200, 4233-4234, 4237-4238, 4241-4242, 4250-4254, 4259-4260, 4266-4276, 4281-4308, 4313-4324, 4388, 4414-4415, 4480-4486, 4569, 4594, 4620-4622, 4689-4690, 4705-4706, 4876-4877, 4880-4881, 4889, 4938-4942, 4993-5000, 5006-5072, 5116, 5168, 5195, 5202-5203, 5212-5215, 5246, 5294-5297, 5300-5306, 5308-5311, 5326-5335, 5338-5339, 5439-5440, 5443, 5445-5450, 5456-5458, 5460, 5469, 5491-5496, 5498-5501, 5505-5506, 5516-5616, 5620-5621, 5636-5637, 5670-5671, 5698-5699, 5732-5759, 5766-5767, 5789-5790, 5809, 5811-5854, 5859-5860, 5862-5863, 5879-5880, 5886-5887, 5891-5894, 5897-5898, 5913-5940, 5948-5949, 5953-5956, 5958-5962, 5980-5984, 6030-6035, 6037-6039, 6055, 6057-6070, 6095-6098, 6142, 6159-6160, 6162-6185, 6200-6201, 6312-6340, 6446-6447, 6467-6468, 6562, 6568-6569, 6592-6611, 6626, 6754, 6776-6814, 6818-6868, 6883, 6892, 6926-6932, 6947-6949, 7091-7094, 7118-7149, 7162, 7164-7172, 7186, 7188-7196, 7203-7206, 7214-7219, 7246-7247, 7252-7254, 7257-7258, 7283-7284, 7315-7316, 7399-7400, 7449-7462, 7528-7531, 7557-7558, 7594-7595, 7608, 7626-7632, 7639-7642, 7665-7671, 7743, 7749, 7764-7771, 7774-7781, 7837, 7914-7915, 7936-7938, 7941, 7955-7979, 8085-8109, 8119-8158, 8171-8172, 8181-8188, 8202-8215, 8228-8235, 8289-8315, 8317-8318, 8392-8393, 8400, 8402-8438, 8467, 8528, 8560-8562, 8587-8592, 8594-8595, 8600-8602, 8605-8625, 8639-8640, 8646-8655, 8660, 8664-8668, 8677-8681, 8684-8689, 8693-8700, 8730, 8732-8736, 8738-8748, 8764-8766, 8777-8785, 8789-8833, 8836-8907, 8915, 8933-8940, 8942-8958, 8973-8995, 9014-9016, 9061-9062, 9176-9180, 9182-9198, 9200-9204, 9216-9217, 9227-9243, 9262-9281, 9283-9284, 9311-9312, 9316-9317, 9327, 9329-9332, 9334-9335, 9375, 9396-9397, 9423, 9426, 9467, 9479-9487, 9504-9505, 9537-9540, 9633-9640, 9666-9667, 9710-9764, 9812-9813, 9822-9825, 9830-9831, 9852-9854, 9856-9860, 9898
packages/excalidraw/element/newElement.ts 91.93% 91.83% 84.21% 91.93% 142-147, 150-157, 177-191, 209, 357-358, 447, 453-454, 469-486, 523-524
Generated in workflow #2539

@ryan-di ryan-di marked this pull request as ready for review May 17, 2024 14:55
@dwelle dwelle enabled auto-merge (squash) May 21, 2024 14:30
@dwelle dwelle disabled auto-merge May 21, 2024 14:56
@dwelle dwelle merged commit c540bd6 into master May 21, 2024
11 checks passed
@dwelle dwelle deleted the paste-long-texts branch May 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwelle dwelle dwelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR - set an automatic width when pasting a long text
2 participants
@ryan-di @dwelle