Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to use --buildkit-container-name to have released earthly cli connect to local dev version of buildkit #4122

Closed
alexcb opened this issue May 16, 2024 · 0 comments · Fixed by #4132
Closed

unable to use --buildkit-container-name to have released earthly cli connect to local dev version of buildkit #4122

alexcb opened this issue May 16, 2024 · 0 comments · Fixed by #4132
Labels
type:bug Something isn't working

Comments

@alexcb
Copy link
Collaborator

alexcb commented May 16, 2024

What went wrong?

earthly-v0.8.9 --no-buildkit-update --buildkit-container-name earthly-dev-buildkitd +foo

fails with:

           buildkitd | Found buildkit daemon as docker container (earthly-dev-buildkitd)
           buildkitd | Updated image available. But update was inhibited.
Error: connection error: desc = "error reading server preface: command [docker exec -i earthly-buildkitd buildctl dial-stdio] has exited with exit status 1, please make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=Error response from daemon: No such container: earthly-buildkitd\n"

note that it is referencing earthly-buildkitd rather than earthly-dev-buildkitd.

What should have happened?

the value of --buildkit-container-name should be used.

What earthly version?

latest

Buildkit Logs

No response

Other Helpful Information

No response
@alexcb alexcb added the type:bug Something isn't working label May 16, 2024
alexcb added a commit that referenced this issue May 17, 2024
@alexcb
fix: --buildkit-container-name was ignored when --no-buildkit-update …
ad6e789 
…was set

fixes #4122

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
alexcb added a commit that referenced this issue May 17, 2024
@alexcb
fix: --buildkit-container-name was ignored when --no-buildkit-update …
85f15ae 
…was set

fixes #4122

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
alexcb added a commit that referenced this issue May 17, 2024
@alexcb
fix: --buildkit-container-name was ignored when --no-buildkit-update …
ca2f67c 
…was set

fixes #4122

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb alexcb mentioned this issue May 17, 2024
Merged
alexcb added a commit that referenced this issue May 17, 2024
@alexcb
fix: --buildkit-container-name was ignored when --no-buildkit-update …
f23d28d 
…was set

fixes #4122

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
alexcb added a commit that referenced this issue May 17, 2024
@alexcb
fix: --buildkit-container-name was ignored when --no-buildkit-update …
4b19a4c 
…was set

fixes #4122

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb alexcb closed this as completed in e1120dd May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: --buildkit-container-name was ignored when --no-buildkit-update was set earthly/earthly
1 participant
@alexcb