Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError: AbortController is not defined in 3.45.0 because of recent changes #2243

Open
arpithparikh opened this issue Aug 20, 2023 · 5 comments
Labels

Comments

@arpithparikh
Copy link

arpithparikh commented Aug 20, 2023

Affected Projects
React

Library Version: x.y.z

3.45.0

Describe the bug

I started getting errors in my live project for version 3.45.0 because of recent fixes.
ReferenceError: AbortController is not defined
node_modules/@appbaseio/reactivesearch/node_modules/appbase-js/dist/appbase-js.cjs.js (456:26)

Kindly please fix it or "appbase-js": "^5.3.4" to 5.0.1

This is the error!!!!!!
var controller = new AbortController();
var signal = controller.signal;

To Reproduce
Steps to reproduce the behavior:
Run the project using 3.45.0

node version v14.16.1
6.14.12

@arpithparikh
Copy link
Author

arpithparikh commented Aug 21, 2023

cc @siddharthlatest - Please review asap.

Have found a workaround for this. https://www.npmjs.com/package/node-abort-controller

Please add node version v14.16.1 compatibility for app base 3.45.0

@siddharthlatest
Copy link
Member

@arpithparikh It seems Node 14.17.3 (LTS) may support this and still work despite being EOL'ed earlier this year. I would recommend considering to upgrade to a supported version, or v3 (before 3.45.0 release) should work well in this case.

@arpithparikh
Copy link
Author

Hi @siddharthlatest - I tried before the 3.45.0 release but it didn't work

@siddharthlatest
Copy link
Member

@arpithparikh I would suggest using 3.43.10 and you can share the stack trace if you're seeing an error. Abort controller isn't present in this release.

@arpithparikh
Copy link
Author

@siddharthlatest - can you please list down the difference between 3.45.0 and 3.43.10? We can't simply change to a backward version. Also, I would suggest only putting new fixes for new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants