Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if no credentials in ReactiveBase even if not using AppBase #2204

Open
scottroot opened this issue Apr 4, 2023 · 4 comments
Open

Error if no credentials in ReactiveBase even if not using AppBase #2204

scottroot opened this issue Apr 4, 2023 · 4 comments
Labels

Comments

@scottroot
Copy link

Affected Projects
React

Library Version: x.y.z
"@appbaseio/reactivesearch": "4.0.0-rc.3"

Describe the bug
With ReactiveBase, if there are no credentials provided for AppBase then there is a breaking error. Even if connecting to your own ES instance. I had to look up my credentials on appbase from a trial I did and enter that and it doesn't error now.

Expected behavior
I am connecting ReactiveSearch to my own ElasticCloud instance, not to AppBase so should not need appbase credentials in this component.

@scottroot scottroot added the bug label Apr 4, 2023
@parthvnp
Copy link

parthvnp commented May 8, 2023

Happy to look into this and provide a fix.

@SavvyShah
Copy link
Contributor

Only appbase instance is supported from v4 of library i.e enableAppbase is true always. You would either need to setup a gateway using reactivesearch-api or use Reactivesearch managed elasticsearch instance which would need no setup.

@noams-unbiased
Copy link

@SavvyShah is this a bug? will the package maintain support of the old way? or is this a breaking change that's here to stay?

@siddharthlatest
Copy link
Member

@noams-unbiased This is a breaking change that's here to stay. ReactiveSearch UI kit requires use of ReactiveSearch cloud as a backend, more on this in the migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants