Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI translation for Serbian language #3276

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

novta
Copy link

@novta novta commented Feb 5, 2024

No description provided.

@novta
Copy link
Author

novta commented Feb 6, 2024

What is problem with those tests? There are no free space in POedit group, I expected simple json translation would be enough.
How to translate UI to Serbian and deploy?

@kantord
Copy link
Owner

kantord commented Feb 11, 2024

What is problem with those tests? There are no free space in POedit group, I expected simple json translation would be enough. How to translate UI to Serbian and deploy?

what do you mean there is no free space in the POedit group, you mean you are not able to join and contribute the translation keys there?

Adding the JSON is an option, I mean, it is possible to manually import it into POeditor, but the correct way should be to contribute through POeditor and automatically export the translation keys into the repo.

If it's not possible to contribute through POeditro that is a problem, it means we need to find an alternative to poeditor

@kantord
Copy link
Owner

kantord commented Feb 11, 2024

The failing tests are not a problem with this PR or Poeditor, so don't worry about those

@novta
Copy link
Author

novta commented Feb 11, 2024

When I try to join to community https://poeditor.com/join/project/jKiKfen2Ye with my account I get next message This project can't accept new contributors at this time. Please try again later.
image

@novta
Copy link
Author

novta commented Feb 11, 2024

So if test are not consequence of localization it can be merged. Is that correct?

@EmanuelLoos
Copy link

The reason why it does not work through POeditor is that there are some translation keys missing. Therefore POeditor says that the translation is complete when it actually is not. This PR seems to add some more translation keys where the English strings are currently hardcoded. I think it should be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants