Voice samples for card and selection challenges, fixes #617 #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given, fixes kantord#677" This reverts commit 0846fdd. wrong branch
yes, this would work! 🚀 you can handle it in a second merge request, if you want |
kantord
requested changes
Jul 3, 2023
There was a problem hiding this comment.
it looks good to me! 🚀
however, there are some failures in the tests. it looks like it's because a lot of test cases test the format of the json, and the audios need to be included.
could you please fix it? and let me know if you need help, we can jump on a call: https://app.harmonizely.com/harmonizely-uoicqk
|
Yeah I'll try to have a look at those soon, I've been a bit busy lately but hopefully I'll have some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voice samples now play whenever the selected card or phrase changes to a non-null value, audio is added to these challenge types as well.
I haven't edited the feature files because I'm not sure exactly what details I would put in there, something like this maybe?