-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If no MX records found #35
Comments
plus, you would give 2 separate variables for HELO server and for USER |
Hello and thanks for the feedback! Line 285 is empty on current master: https://github.com/zytzagoo/smtp-validate-email/blob/master/src/Validator.php#L285 -- so I'm not really following what you're talking about. The test suite is there, feel free to provide a test case that exhibits the behaviour you encounter (ideally maybe even a PR for a fix if it turns out something is really broken!). Regarding customising the HELO sent, are you up for doing a PR for that too and allow it to be easily customised from the outside? (It should also preserve back-compat for existing users) |
Helo, just try to check this address: blabla@blablabla.bla |
or, better, this one, from real life: zzmusic@zzmusic.com (caused problem) |
p.s. sorry, I made changes in code, so 285 was a wrong line number, correct, but just find a line:
as a minimum, for every address in array (I check only 1 address per time, so this easy solution works for me) :) |
One more thing, checking several addresses at ones from one host (in your second example), maybe is not very good idéa, imho, it can lead to blacklist directly.. otherwise, is a very nice script, tnx for jour job :) About HELO, everybody please check this: The HELO string sent should in the style of: Example: The following bad example(s) will get rejected: Source https://www.linuxmagic.com/best_practices/valid_helo_domain.html Take a look at "hostnameonly" line.. p.s. valid HELO = mail.server.com (MX server which belongs to your email address) Best regards |
Im not sure if this is the same issue but I was validating an address that seems to be incorrect: something@archlabslinux.com , the domain exists but the MX does not, and seems like smtp-validate-email returns a FALSE positive for connecting to an invalid MX server (which says 0.0.0.0), see the logs:
|
If domain dosn't exist your script fails, hangs up and kills server
line 285
there must be "if mxQuery" ($hosts, $weights) or false (no MX servers = fake domain)
you even don't have NoMX.php in your Exceptions folder ;)
it's a good script, otherwise :)
The text was updated successfully, but these errors were encountered: