Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting doesn't work when using both marlonrichert/zsh-autocomplete and zsh-users/zsh-syntax-highlighting #145

Open
kinland opened this issue Feb 27, 2023 · 2 comments

Comments

@kinland
Copy link

kinland commented Feb 27, 2023

There appears to be a compatibility issue between zsh-history-substring-search and these modules:

  • zsh-users/zsh-syntax-highlighting
  • zsh-users/zsh-autosuggestions
  • zsh-users/zsh-syntax-highlighting

It seems that when I try to enable all 4 plugins, syntax highlighting doesn't work with zsh-history-substring-search. However, disabling either zsh-autocomplete or zsh-syntax-highlighting causes highlighting to function properly.

Working (listed order is load order):

  • zsh-syntax-highlighting + zsh-history-substring-search
  • zsh-autosuggestions + zsh-syntax-highlighting + zsh-history-substring-search
  • zsh-autocomplete + zsh-autosuggestions + zsh-history-substring-search

Not working (changing the order doesn't seem to help):

  • zsh-autocomplete + zsh-autosuggestions + zsh-syntax-highlighting + zsh-history-substring-search

Incidentally, replacing zsh-syntax-highlighting with fast-syntax-highlighting seems to make things work. Highlighting is a little different, but close.

Possibly related to marlonrichert/zsh-autocomplete#517

@Caellian
Copy link

Caellian commented Nov 5, 2023

Just having zsh-autosuggestions + zsh-history-substring-search (in any order) breaks autosuggestion highlighting.

All of these are trying to do the same thing "modify styling on the current line" and I think it's near impossible to coordinate them to all work together without merging them into a single plugin.

Based on the fact that people are suggesting to set the HIGHLIGHT_STYLE to white, it seems like it's not an obscure issue.

@hugopeek
Copy link

This same thing happened to me when configuring a new workstation, while on the old unit it was still working.. So I backtracked through both the autosuggestions and history-substring repos and did a few checkouts to earlier commits.

It seems the issue was introduced in this repository, with commit b4fb93d. If I revert to the commit before (563a551), the behaviour is back to normal again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants