Fix deferred compdef between sourcing antigen and antigen apply #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using some obscure Zsh syntax, check https://zsh.sourceforge.io/Doc/Release/Expansion.html#Parameter-Expansion-Flags for documentation about it. Fixes zsh-users#736
|
This seems to only fix the no/stale cache case, when the cache is enabled, there is no |
|
Modified so it also fixes the caching case. |
Avoids the for loop iterating an empty variable and calling `compdef` with no arguments
|
Can this be reviewed and unblocked for merge please. Impacted from #736 |
|
Sadly this project seems unmaintained for quite some time and the original maintainers haven't appointed anyone new to take over. |
|
If you want to manually patch your local antigen install: antigen-deferred-compdef-fix.patch.tar.gz patch -p2 -i antigen-deferred-compdef-fix.patch |
|
Thank you for your fix @segevfiner! It's a pity this project no longer seems maintained. |
popstas
added a commit
to viasite-ansible/ansible-role-zsh
that referenced
this pull request
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using some obscure Zsh syntax, check https://zsh.sourceforge.io/Doc/Release/Expansion.html#Parameter-Expansion-Flags for documentation about it.
Fixes #736