Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to timeout only for GET requests ? #197

Closed
loicginoux opened this issue Jan 16, 2023 · 1 comment
Closed

possibility to timeout only for GET requests ? #197

loicginoux opened this issue Jan 16, 2023 · 1 comment

Comments

@loicginoux
Copy link

Hello,
I don't see the possibility to configure rack timeout to work only for GET requests. How difficult would it be to add a config to specify which http methods it can timeout (or the ones for which rack timeout is disabled) ?
We would like to drop GET requests in case of timeout but would want to not loose important POST/UPDATE/DELETE requests even if they take too much time.
Thanks

@wuputah
Copy link
Collaborator

wuputah commented May 15, 2024

There's been many requests and several PRs over the years to be able to do this or something similar. The general conclusion has been this is an anti-pattern. The most vigorous debate took place in #110, which I welcome you to review.

I think if we can find a sustainable approach that allows people to customize the behavior, but does not endlessly add more options/option handling, then this might have a future. However, this might require significant refactoring.

In this case I am going to suggest merging any further discussion of this issue into #213. Thanks!

@wuputah wuputah closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants