Remove unconfirmed chain #12973
Open
Remove unconfirmed chain #12973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove chain analysis querying
Legal documents have no place here because zkSNACKs is not going to provide any service related to coinjoins, only develop software.
[FOSS] Remove CJ fee related contents
* Remove `CoinJoinIdStore` This was used mainly to implement the "remixes dont pay" feature, which was added late in the WabiSabi development as an idea to incentivize continue coinjoining, and as a marketing selling point. It was also used as a trivial optimization for the "friends don't pay" or "one hop don't pay" (what requires a full-index bitcoin node)
Wasabi coordinator doesn't charge any coordination fee by default. `Plebs don't pay threshold` is removed because it makes zero sense.
The coinjoin archiver is simple a logger and as such it should be implemented using the logging infrastructure.
It is not used by the wallet.
* Create `ExchangeRateProvider2` * Remove old exchange rate providers and controllers * Fetch exchange rates from the client * Make exchange rate provider configurable * Fix warnings * Naming error * CR feedback * Use Tor to connect to providers Most of the providers are exchanges that block access to their api from Tor. That means that not all providers can be used when Tor is enabled. * Add `User-Agent` to requests Some providers reject the requests if they don't have an User-Agent header. Additionally, using a constant pattern for the requests could help to finger the clients so, we use "random" user agents. * Remove some exchange rate providers that are unreacheable using tor. Add mempool.space as default provider. * Add random delay between queries --------- Co-authored-by: Kiminuo <kiminuo@protonmail.com>
* Add `FeeRateProvider` * Add `FeeRateEstimationUpdater` * Make fee estimation provider configurable * Replace `HybridFeeProvider` with `FeeRateEstimationUpdater` * Add User-Agent, Log entry and small refactoring
* Remove custom request timeouts mechanism * Remove unused things
Refactor UpdateManager and remove UpdateChecker
lontivero
force-pushed
the
remove_unconfirmed_chain
branch
from
2be6438
to
63c8e37
Compare
There are two independent APIs: * WabiSabi for coinjoining and, * Wallet required for providing services to the wallet client to operate.
This reverts commit 176c7df.
* Organize the API There are two independent APIs: * WabiSabi for coinjoining and, * Wallet required for providing services to the wallet client to operate. * Make `/synchronize` a synchronous method
…ctory` (WalletWasabi#13052) CoinJoinProcessor: Pass dependencies properly
lontivero
force-pushed
the
remove_unconfirmed_chain
branch
from
63c8e37
to
11290ec
Compare
lontivero
force-pushed
the
remove_unconfirmed_chain
branch
from
11290ec
to
bf3b786
Compare
|
I've been rebasing this PR to keep it mergeable at any time but I would like to see if it is possible to remove the backend API without removing the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #12318 #12302