Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Exclude coins from coinjoin #12893

Merged
merged 34 commits into from
May 10, 2024

Add Pockets is the source of truth

58b01d8
Select commit
Failed to load commit list.
Merged

[UI] Exclude coins from coinjoin #12893

Add Pockets is the source of truth
58b01d8
Select commit
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (master) failed May 10, 2024 in 57s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method CoinJoinStateViewModel.cs: CoinJoinStateViewModel 🔥

✅ Improving Code Health:

  • Large Method CoinListViewModel.cs: CoinListViewModel

Annotations

Check warning on line 168 in WalletWasabi.Fluent/ViewModels/Wallets/CoinJoinStateViewModel.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)

❌ Getting worse: Large Method 

CoinJoinStateViewModel increases from 78 to 79 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 117 in WalletWasabi.Fluent/ViewModels/Wallets/Coins/CoinListViewModel.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)

✅ Getting better: Large Method 

CoinListViewModel decreases from 91 to 74 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis