Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable a Roslyn analyzer for a subset of trim analysis warnings. #12598

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Enable a Roslyn analyzer for a subset of trim analysis warnings. #12598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e512cdc
Enable a Roslyn analyzer for a subset of trim analysis warnings.
wieslawsoltes Mar 2, 2024
8fd9968
Disable EnableTrimAnalyzer for generators
wieslawsoltes Mar 2, 2024
2783604
Try fixing CI
wieslawsoltes Mar 2, 2024
1ce39dc
Bump .NET SDK version to 8.0.200
wieslawsoltes Mar 2, 2024
383a7d3
Update Avalonia.Xaml.Behaviors to 11.0.9.2
wieslawsoltes Mar 2, 2024
0b7a813
Merge remote-tracking branch 'upstream/master' into EnableTrimAnalyzer
wieslawsoltes Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
<Deterministic>true</Deterministic>
<InvariantGlobalization>true</InvariantGlobalization>
<WarningsAsErrors>false</WarningsAsErrors>
<EnableTrimAnalyzer>true</EnableTrimAnalyzer>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<PackageVersion Include="Avalonia" Version="$(AvaloniaVersion)" />
<PackageVersion Include="Avalonia.Controls.TreeDataGrid" Version="11.0.2" />
<PackageVersion Include="Avalonia.Diagnostics" Version="$(AvaloniaVersion)" />
<PackageVersion Include="Avalonia.Xaml.Behaviors" Version="11.0.5" />
<PackageVersion Include="Avalonia.Xaml.Behaviors" Version="11.0.9.2" />
<PackageVersion Include="Avalonia.Desktop" Version="$(AvaloniaVersion)" />
<PackageVersion Include="Avalonia.ReactiveUI" Version="$(AvaloniaVersion)" />
<PackageVersion Include="Avalonia.Skia" Version="$(AvaloniaVersion)" />
Expand Down
6 changes: 6 additions & 0 deletions WalletWasabi.Daemon/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
"Microsoft.Extensions.Primitives": "8.0.0"
}
},
"Microsoft.NET.ILLink.Tasks": {
"type": "Direct",
"requested": "[8.0.2, )",
"resolved": "8.0.2",
"contentHash": "hKTrehpfVzOhAz0mreaTAZgbz0DrMEbWq4n3hAo8Ks6WdxdqQhNPvzOqn9VygKuWf1bmxPdraqzTaXriO/sn0A=="
},
"Microsoft.Data.Sqlite.Core": {
"type": "Transitive",
"resolved": "8.0.0",
Expand Down
76 changes: 41 additions & 35 deletions WalletWasabi.Fluent.Desktop/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@
"System.Reactive": "5.0.0"
}
},
"Microsoft.NET.ILLink.Tasks": {
"type": "Direct",
"requested": "[8.0.2, )",
"resolved": "8.0.2",
"contentHash": "hKTrehpfVzOhAz0mreaTAZgbz0DrMEbWq4n3hAo8Ks6WdxdqQhNPvzOqn9VygKuWf1bmxPdraqzTaXriO/sn0A=="
},
"Avalonia.Angle.Windows.Natives": {
"type": "Transitive",
"resolved": "2.1.0.2023020321",
Expand Down Expand Up @@ -106,72 +112,72 @@
},
"Avalonia.Xaml.Interactions": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "+FUjkCSqOH/AyIV09uRf8tzJRDXBJA8myssWSJrpNKSVylKo1sMEwokzMPYLt7hQK79LxUVKWZ1ycCaVEloYQg==",
"resolved": "11.0.9.2",
"contentHash": "X07BQiw1QyB7rC78q8TaIP98yrAUe45M6MCod0DRNLbovqF3JTbIVbKfFXwLtE5jkpSI4DsjX5pMzCndn8KYLw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Custom": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "2U6ncgoQSAui3r5tALoAXKg+qf4byyJKJc4jLMaz4I9rYayns2D0aR7vovWL9DQy4IG4bkNvK/HUJVPNvW/JVg==",
"resolved": "11.0.9.2",
"contentHash": "tHeOGQ812PuuMnJeTg1ylz67cgP6mbk4kR79LlejtNraXJKUDggmGMWfZ/zmgVITkuko8YCK9qjaTBWuQt2qPg==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.DragAndDrop": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "fduyJ22rtOBQfVvA5t5pQzLBCVkJK/I9YU1Mmd42+3zzs4CAmyAUEcyfKx51AUDZ1eSWUGs0OhmNSvTugIhjnw==",
"resolved": "11.0.9.2",
"contentHash": "gNcI2V4DjCQELIqYWdtIn/a8ztQSKnwNXOfXZWhoEMQasAo4Yljz1ohvj4jQSVq4Z9FkiYBR7yNdfBDLOp9b/w==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Draggable": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "5koY9NubWzUZs7esB2sCT7RfCrjgxnJTyWMUWvw/DXiYwuCWK4Lxot1p56GvVLZDYm5xaR+AfXgTXd3AETHqhg==",
"resolved": "11.0.9.2",
"contentHash": "Ch/JxLSxk4GA5ltlrwT6unL3njhkuGD689DqTVPMVapswW2CT2KByFx+H1TNMTg08amxAwykGkiseNYvePh0cQ==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Events": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "HsqvSWpV7fe0MogKEmyzMSUPqyod1eMPJetNwENDFdjLuAZbSjbIjHvPLWi4AjbaSf25YMSRBsXqRA9oVJCPsA==",
"resolved": "11.0.9.2",
"contentHash": "9nlq62zX++W1u5cb7lH9LOtfp+ZGslXDnEvWIAOd1cbhrNhCuLQk1I7hV0nvbaNdgk6rMUzRSph/JHxSkvoNYw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Reactive": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "uezG/QDpxASYc9yCk2vm3b4hZUzsVlp0TtrAMF9B5KHpVN/necKz+/sEjmH8p4jhNoVFPnsoXzIbesx4YY0Oug==",
"resolved": "11.0.9.2",
"contentHash": "xaswIxDq2ndGODnX1Y6jhIKRxeU4TeALs4/AFjJ1Xy4DCFI2uux3kfBqLiUB65cTAc156k2UJoTwSRcF802ggw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5",
"Avalonia.Xaml.Interactivity": "11.0.9.2",
"System.Reactive": "5.0.0"
}
},
"Avalonia.Xaml.Interactions.Responsive": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "jm6PldRWuTKzWJmrP0qRajYNS3FhpbqsZPTJ2wAHkCsv1NrsGya5oU4F1lYJUXc6AvM1BZ0QYlf+UuKt+D/Lxg==",
"resolved": "11.0.9.2",
"contentHash": "32xKAGyggzm6D47VDbuImTe8CkDjK/PwpICeNXxmW2yDewoxv+gyzGnnWiKtaDy7PHVnC5U19UtCeuVN6P41Bw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactivity": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "B/1VU7v8u2tqOzee9SjICBSJfiIcuiQF8Ngqv80zKKNU38qQ++zFweAZ2q7qgCYaBvny8NakEfBnpMhroMdDmA==",
"resolved": "11.0.9.2",
"contentHash": "lRq3LRkaho9gXKSszhJn7ALH8tUY+GcDDV/yzYkyuOYAaKJqponUNCU55eN1K3LbyvWS18UJtPeBA0t4I40ksQ==",
"dependencies": {
"Avalonia": "11.0.0"
}
Expand Down Expand Up @@ -823,7 +829,7 @@
"Avalonia.ReactiveUI": "[11.0.999-cibuild0044755-beta, )",
"Avalonia.Skia": "[11.0.999-cibuild0044755-beta, )",
"Avalonia.Themes.Fluent": "[11.0.999-cibuild0044755-beta, )",
"Avalonia.Xaml.Behaviors": "[11.0.5, )",
"Avalonia.Xaml.Behaviors": "[11.0.9.2, )",
"DynamicData": "[8.1.1, )",
"QRackers": "[1.1.0, )",
"System.Runtime": "[4.3.1, )",
Expand Down Expand Up @@ -908,19 +914,19 @@
},
"Avalonia.Xaml.Behaviors": {
"type": "CentralTransitive",
"requested": "[11.0.5, )",
"resolved": "11.0.5",
"contentHash": "tBh1SAiNpOKGH5GGfxYPIqksjE97Z6gS2dtR6UZJ+irqgyC4+slqVOiRMvg7tu6uPahXv1/D3SGYrU5iPhFJNg==",
"requested": "[11.0.9.2, )",
"resolved": "11.0.9.2",
"contentHash": "JFjLmgbXiAaPwCt++60iwEA117jl/vrVCTjdqycNn43BiH3StDDAphSJcWhlPIDwviehlGoBmkR3VdKEgYhYpA==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactions": "11.0.5",
"Avalonia.Xaml.Interactions.Custom": "11.0.5",
"Avalonia.Xaml.Interactions.DragAndDrop": "11.0.5",
"Avalonia.Xaml.Interactions.Draggable": "11.0.5",
"Avalonia.Xaml.Interactions.Events": "11.0.5",
"Avalonia.Xaml.Interactions.Reactive": "11.0.5",
"Avalonia.Xaml.Interactions.Responsive": "11.0.5",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactions": "11.0.9.2",
"Avalonia.Xaml.Interactions.Custom": "11.0.9.2",
"Avalonia.Xaml.Interactions.DragAndDrop": "11.0.9.2",
"Avalonia.Xaml.Interactions.Draggable": "11.0.9.2",
"Avalonia.Xaml.Interactions.Events": "11.0.9.2",
"Avalonia.Xaml.Interactions.Reactive": "11.0.9.2",
"Avalonia.Xaml.Interactions.Responsive": "11.0.9.2",
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"DynamicData": {
Expand Down
1 change: 1 addition & 0 deletions WalletWasabi.Fluent.Generators/WalletWasabi.Fluent.Generators.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<PathMap>$(MSBuildProjectDirectory)\=WalletWasabi.Fluent.Generators</PathMap>
<IsRoslynComponent>true</IsRoslynComponent>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<EnableTrimAnalyzer>false</EnableTrimAnalyzer>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Directory.Build.props contains this line.

</PropertyGroup>

<ItemGroup>
Expand Down
74 changes: 40 additions & 34 deletions WalletWasabi.Fluent/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,19 @@
},
"Avalonia.Xaml.Behaviors": {
"type": "Direct",
"requested": "[11.0.5, )",
"resolved": "11.0.5",
"contentHash": "tBh1SAiNpOKGH5GGfxYPIqksjE97Z6gS2dtR6UZJ+irqgyC4+slqVOiRMvg7tu6uPahXv1/D3SGYrU5iPhFJNg==",
"requested": "[11.0.9.2, )",
"resolved": "11.0.9.2",
"contentHash": "JFjLmgbXiAaPwCt++60iwEA117jl/vrVCTjdqycNn43BiH3StDDAphSJcWhlPIDwviehlGoBmkR3VdKEgYhYpA==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactions": "11.0.5",
"Avalonia.Xaml.Interactions.Custom": "11.0.5",
"Avalonia.Xaml.Interactions.DragAndDrop": "11.0.5",
"Avalonia.Xaml.Interactions.Draggable": "11.0.5",
"Avalonia.Xaml.Interactions.Events": "11.0.5",
"Avalonia.Xaml.Interactions.Reactive": "11.0.5",
"Avalonia.Xaml.Interactions.Responsive": "11.0.5",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactions": "11.0.9.2",
"Avalonia.Xaml.Interactions.Custom": "11.0.9.2",
"Avalonia.Xaml.Interactions.DragAndDrop": "11.0.9.2",
"Avalonia.Xaml.Interactions.Draggable": "11.0.9.2",
"Avalonia.Xaml.Interactions.Events": "11.0.9.2",
"Avalonia.Xaml.Interactions.Reactive": "11.0.9.2",
"Avalonia.Xaml.Interactions.Responsive": "11.0.9.2",
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"DynamicData": {
Expand All @@ -108,6 +108,12 @@
"System.Reactive": "6.0.0"
}
},
"Microsoft.NET.ILLink.Tasks": {
"type": "Direct",
"requested": "[8.0.2, )",
"resolved": "8.0.2",
"contentHash": "hKTrehpfVzOhAz0mreaTAZgbz0DrMEbWq4n3hAo8Ks6WdxdqQhNPvzOqn9VygKuWf1bmxPdraqzTaXriO/sn0A=="
},
"QRackers": {
"type": "Direct",
"requested": "[1.1.0, )",
Expand Down Expand Up @@ -165,72 +171,72 @@
},
"Avalonia.Xaml.Interactions": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "+FUjkCSqOH/AyIV09uRf8tzJRDXBJA8myssWSJrpNKSVylKo1sMEwokzMPYLt7hQK79LxUVKWZ1ycCaVEloYQg==",
"resolved": "11.0.9.2",
"contentHash": "X07BQiw1QyB7rC78q8TaIP98yrAUe45M6MCod0DRNLbovqF3JTbIVbKfFXwLtE5jkpSI4DsjX5pMzCndn8KYLw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Custom": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "2U6ncgoQSAui3r5tALoAXKg+qf4byyJKJc4jLMaz4I9rYayns2D0aR7vovWL9DQy4IG4bkNvK/HUJVPNvW/JVg==",
"resolved": "11.0.9.2",
"contentHash": "tHeOGQ812PuuMnJeTg1ylz67cgP6mbk4kR79LlejtNraXJKUDggmGMWfZ/zmgVITkuko8YCK9qjaTBWuQt2qPg==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.DragAndDrop": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "fduyJ22rtOBQfVvA5t5pQzLBCVkJK/I9YU1Mmd42+3zzs4CAmyAUEcyfKx51AUDZ1eSWUGs0OhmNSvTugIhjnw==",
"resolved": "11.0.9.2",
"contentHash": "gNcI2V4DjCQELIqYWdtIn/a8ztQSKnwNXOfXZWhoEMQasAo4Yljz1ohvj4jQSVq4Z9FkiYBR7yNdfBDLOp9b/w==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Draggable": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "5koY9NubWzUZs7esB2sCT7RfCrjgxnJTyWMUWvw/DXiYwuCWK4Lxot1p56GvVLZDYm5xaR+AfXgTXd3AETHqhg==",
"resolved": "11.0.9.2",
"contentHash": "Ch/JxLSxk4GA5ltlrwT6unL3njhkuGD689DqTVPMVapswW2CT2KByFx+H1TNMTg08amxAwykGkiseNYvePh0cQ==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Events": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "HsqvSWpV7fe0MogKEmyzMSUPqyod1eMPJetNwENDFdjLuAZbSjbIjHvPLWi4AjbaSf25YMSRBsXqRA9oVJCPsA==",
"resolved": "11.0.9.2",
"contentHash": "9nlq62zX++W1u5cb7lH9LOtfp+ZGslXDnEvWIAOd1cbhrNhCuLQk1I7hV0nvbaNdgk6rMUzRSph/JHxSkvoNYw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactions.Reactive": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "uezG/QDpxASYc9yCk2vm3b4hZUzsVlp0TtrAMF9B5KHpVN/necKz+/sEjmH8p4jhNoVFPnsoXzIbesx4YY0Oug==",
"resolved": "11.0.9.2",
"contentHash": "xaswIxDq2ndGODnX1Y6jhIKRxeU4TeALs4/AFjJ1Xy4DCFI2uux3kfBqLiUB65cTAc156k2UJoTwSRcF802ggw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5",
"Avalonia.Xaml.Interactivity": "11.0.9.2",
"System.Reactive": "5.0.0"
}
},
"Avalonia.Xaml.Interactions.Responsive": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "jm6PldRWuTKzWJmrP0qRajYNS3FhpbqsZPTJ2wAHkCsv1NrsGya5oU4F1lYJUXc6AvM1BZ0QYlf+UuKt+D/Lxg==",
"resolved": "11.0.9.2",
"contentHash": "32xKAGyggzm6D47VDbuImTe8CkDjK/PwpICeNXxmW2yDewoxv+gyzGnnWiKtaDy7PHVnC5U19UtCeuVN6P41Bw==",
"dependencies": {
"Avalonia": "11.0.0",
"Avalonia.Xaml.Interactivity": "11.0.5"
"Avalonia.Xaml.Interactivity": "11.0.9.2"
}
},
"Avalonia.Xaml.Interactivity": {
"type": "Transitive",
"resolved": "11.0.5",
"contentHash": "B/1VU7v8u2tqOzee9SjICBSJfiIcuiQF8Ngqv80zKKNU38qQ++zFweAZ2q7qgCYaBvny8NakEfBnpMhroMdDmA==",
"resolved": "11.0.9.2",
"contentHash": "lRq3LRkaho9gXKSszhJn7ALH8tUY+GcDDV/yzYkyuOYAaKJqponUNCU55eN1K3LbyvWS18UJtPeBA0t4I40ksQ==",
"dependencies": {
"Avalonia": "11.0.0"
}
Expand Down
6 changes: 6 additions & 0 deletions WalletWasabi.Packager/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"version": 2,
"dependencies": {
"net8.0": {
"Microsoft.NET.ILLink.Tasks": {
"type": "Direct",
"requested": "[8.0.2, )",
"resolved": "8.0.2",
"contentHash": "hKTrehpfVzOhAz0mreaTAZgbz0DrMEbWq4n3hAo8Ks6WdxdqQhNPvzOqn9VygKuWf1bmxPdraqzTaXriO/sn0A=="
},
"Microsoft.Data.Sqlite.Core": {
"type": "Transitive",
"resolved": "8.0.0",
Expand Down
6 changes: 6 additions & 0 deletions WalletWasabi/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@
"Microsoft.Extensions.Options": "8.0.0"
}
},
"Microsoft.NET.ILLink.Tasks": {
"type": "Direct",
"requested": "[8.0.2, )",
"resolved": "8.0.2",
"contentHash": "hKTrehpfVzOhAz0mreaTAZgbz0DrMEbWq4n3hAo8Ks6WdxdqQhNPvzOqn9VygKuWf1bmxPdraqzTaXriO/sn0A=="
},
"Microsoft.Win32.SystemEvents": {
"type": "Direct",
"requested": "[8.0.0, )",
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- task: UseDotNet@2
displayName: 'Install .NET'
inputs:
version: 8.0.x
useGlobalJson: true
- task: DotNetCoreCLI@2
displayName: 'Restore'
inputs:
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines-osx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- task: UseDotNet@2
displayName: 'Install .NET'
inputs:
version: 8.0.x
useGlobalJson: true
- task: DotNetCoreCLI@2
displayName: 'Restore'
inputs:
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- task: UseDotNet@2
displayName: 'Install .NET'
inputs:
version: 8.0.x
useGlobalJson: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

However, I wonder what it leads to in practice. If I understand correctly, it can happen that, for example, we would test against https://github.com/dotnet/runtime/releases/tag/v8.0.2 and not against 8.0.3 because 8.0.3 can be on a newer SDK (e.g. 8.0.300).

Is it how it works or not?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/en-us/dotnet/core/versions/#versioning-details

- task: DotNetCoreCLI@2
displayName: 'Restore'
inputs:
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.100",
"version": "8.0.200",
"allowPrerelease": false,
"rollForward": "latestFeature"
}
Expand Down