[Autocoinjoin] Freeze utxo from coinjoin

[MaxHillebrand]

Currently all utxos are eligable to be registerd for coinjoin. However, there are many good reasons why some specific utxo does not need to be coinjoined.

For example, a trader withdrawls from an exchange in evening, knowing that he will deposit again in the morning. He is sending to the same entity, and thus there is no need to pay for blockspace to get privacy.

I see two ways of implementing this:

1. In the coin list, have a button or right click menu with Freeze from coinjoin. The coin will only be registered if the user clicks Unfreeze from coinjoin. However, the coin should still be considered for coin selection for single user payments.

2. In the receive tab when generating a new address, the user can click on a checkbox with Don't coinjoin this address. This would be more direct in the default UX and would be seen on every receive dialog. Since we should probalby not encourage this opt-out feature by default, I would prefer the first approach.

[MaxHillebrand]

this coinjoin icon could be clickable so that it toggles to strike through, indicating that this coin is frozen. when icon is clicked again, the strike-through disappears and the coin will be registered again.

[stale]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[soosr]

cACK

[BTCparadigm]

cACK

[tricopol]

This is an absolute must for me. I'd love to hear what was the rationale behind releasing 2.x without this feature.

[tricopol]

1. In the coin list, have a button or right click menu with Freeze from coinjoin. The coin will only be registered if the user clicks Unfreeze from coinjoin. However, the coin should still be considered for coin selection for single user payments.

Please make sure you can select multiple (or all) coins (like you do Ctrl-A or shift-select in Windows Explorer) in a single pass instead of having to click each coin individually. If i have 100 coins and want to coinjoin 5 of them, freezing 95 one-by-one will get tedious..

[molnard]

Business logic is done but the UI is unusable - this is as planned. They do not know if the coin is frozen or not, nor how to freeze a coin. The VDG team will take over from this point. Pinging @nopara74

[Szpoti]

@zkSNACKs/visual-design-group What's up with this?

[soosr]

@zkSNACKs/visual-design-group What's up with this?

Hiring a UX designer is in progress, we will wait with this issue (and some others) to see what are their thoughts about the possible solution.

[lukasdll]

There is already a checkbox and an "action menu" at the bottom with "send selected coins".

Wouldn't it be more intuitive for the user to add the actions "exclude from CoinJoin" and "include in CoinJoin" at the same location, and those actions be applied on the selected coins?

The multi-selection idea, via a combination of keys CTRL+SHIFT, would then improve the inclusion, exclusion but also the submission (via "send selected coins").

We could eventually make buttons out of it, instead of underlined texts.

For the icon, I would like to suggest using the "Ready to CoinJoin" / "CoinJoining" / "Can't participate in CoinJoin until", to include another symbol indicating that the coin has been excluded from CoinJoins manually, as it seems a better place from a "semantic" point of view than the "V" location, that instead seems to indicate whether the coin is an UTXO from a confirmed transaction.

Perhaps we could add a grey colored "Stop hand" to indicate the exclusion of the coin.

An idea of icon:

[soosr]

@lukasdll

We should rather remove features from the wallet coins dialog. Initially, it was introduced only for developers to help with the development.
Introducing the "Send whole coin" feature was rushed back then, and this dialog was the only place it could be added.
A feature like that or Freeze coins should not only be accessible via a magic key combo and they should be placed where it makes sense.
Send whole coins should be put somewhere around Send, while the Freeze coins should be put somewhere around Coinjoin player.
This topic will be discussed soon among the UX team.

[soosr]

Reached an agreement in terms of UX and UI designs.

• Replace the LED indicator with a ... menu in MusicBox
  • (this will allow us to add Coinjoin related stuff there)
• Add a Exclude Coins options, which pop a dialog with the list of coins.

The team will start to work on it after the UI Refreshment.

[nostitos]

Another very common reason to not want to automix all new deposits is that people might want to save on fees and complexity of having two wallets and paying for extra transaction when they want to mix it.

Unless the user is a coin selection expert, That extra transaction is most likely consolidating coins costing a lot in lost privacy.

[MarnixCroes]

closing, as #12893 was merged